feat: Migrate logger to js-toolkit logger implementation #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/client/package.json # sample-apps/react-native/dogfood/src/components/BottomControlsDrawer.tsx # yarn.lock
- update logger version
- remove default string
- update @stream-io/loggers package
- update @stream-io/loggers package - add @stream-io/loggers as seperate package in react-native-sdk and
- update old imports
- revert level usage
Comment on lines
+40
to
+41
| logger: Logger, | ||
| level: LogLevel, |
There was a problem hiding this comment.
It'd be good to add a function description which mentions that these two arguments set the default scope and that providing a different value in the config (third argument) might override these two, let's also deprecate the signature in favor of using the one coming from the package.
Comment on lines
98
to
102
| setLogger( | ||
| rootLogger, | ||
| clientOptions?.logLevel || 'warn', | ||
| clientOptions?.logOptions, | ||
| ); |
There was a problem hiding this comment.
We can probably use the new signature here since it's our code.
Comment on lines
+201
to
203
| console.warn( | ||
| '[filters] Filter encountered an error and will be disabled', | ||
| ); |
There was a problem hiding this comment.
Why are we sinking logs to console here? 🤔
arnautov-anton
approved these changes
Oct 20, 2025
- set deprecated on setLogger level and use the new configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Migrated usage of
getLoggerto new syntax where the first tag is considered as scope and the subsequent are tags.Introduced new configuration option:
logOptions?: ConfigureLoggersOptions<string>which allows the consumers to configure the loggers per scopeMarked
loggerandlogLevelas deprecated and in first implementation setting them as defaultlevelandlevelinconfigureLoggers📝 Implementation notes
📑 Docs: https://github.com/GetStream/docs-content/pull/