Skip to content

Conversation

salome-voltz
Copy link
Collaborator

@salome-voltz salome-voltz commented Aug 20, 2025

Context

Git has a security feature that prevents executing commands in repositories owned by different users. This causes "dubious ownership" errors. This MR adds safe.directory=* configuration to all git commands to bypass ownership checks.

Validation

Create a repository as user A and run ggshield scan as user B. No error should be displayed.

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (49887e9) to head (7dde64b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         144      144           
  Lines        6162     6162           
=======================================
  Hits         5669     5669           
  Misses        493      493           
Flag Coverage Δ
unittests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@salome-voltz salome-voltz marked this pull request as ready for review August 20, 2025 15:04
@salome-voltz salome-voltz requested a review from a team as a code owner August 20, 2025 15:04
@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5812-investigate-ggshield-running-into-an-ownership-issue-in-git branch from e7eb743 to 1fd8826 Compare August 21, 2025 13:47
@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5812-investigate-ggshield-running-into-an-ownership-issue-in-git branch from 1fd8826 to 99b7c93 Compare August 21, 2025 13:50
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor remarks.

@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5812-investigate-ggshield-running-into-an-ownership-issue-in-git branch from 62b2c93 to 7dde64b Compare August 22, 2025 09:00
@agateau-gg agateau-gg merged commit 321e951 into main Aug 22, 2025
28 checks passed
@agateau-gg agateau-gg deleted the salomevoltz/scrt-5812-investigate-ggshield-running-into-an-ownership-issue-in-git branch August 22, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants