Adds a no-cache header to slack error responses #944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db10980 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
commit: |
valentin0h
commented
Aug 15, 2025
| }); | ||
| return new Response(JSON.stringify(completions), { | ||
| headers: { | ||
| 'Content-Type': 'application/json', |
There was a problem hiding this comment.
removed caching from here, let gitbook handle caching
valentin0h
commented
Aug 15, 2025
| status: error instanceof ExposableError ? error.code : 500, | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'Cache-Control': 'no-cache, no-store', |
There was a problem hiding this comment.
Error responses shouldn't be cached.
There was a problem hiding this comment.
The idea is to fix the logic in gitbook, not to cache error responses, but I want to validate that this works regardless.
|
Fixed in gitbook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the wrong fix #935. The error response is what gets cached first due to the lack of authentication permissions.
I want to test if this works as expected before I make any changes to gitbook-x