-
-
Notifications
You must be signed in to change notification settings - Fork 371
feat(cli): blame --ignore-rev/--ignore-revs-file (#2064) #2125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…transparent attribution and tests
…e Default/Clone/Debug; tests
…uild after private field
…f to upstream state
AI-Assisted: Claude Code AI-Agent-Mode: no AI-MultiLine-Completions: yes (pasted then edited/reviewed) human-reviewed; clippy+tests green:
…ined-format-args)
d2e7baa
to
f261c92
Compare
CI note: The errors that appeared to have failed are due to: gix-url::issue2064_scp_username::* that test file isn’t present on current upstream/main I’ve rebased onto the latest main and retriggered CI. |
I wouldn't expect rebasing to affect the failures--and it doesn't seem to have affected them--because this PR itself introduces that test file in ali90h@c8bdddd. |
Sorry, I'll check it out. |
Just to set expectations: since this seems partly/mostly LLM-generated, this makes the PR harder to review, so it is probably going to take longer than if the code had been written by a human. |
“Acknowledged. I’ve disclosed AI assistance and add commit trailers. Review focus and a repro script are in the PR body. I’m responsive to changes and happy to adjust.” |
4ee51e3
to
c6ca617
Compare
I hope it's okay that I've rebased to drop the second-to-last commit, f261c92. This was an intentionally empty commit, which had been pushed as a workaround to force CI to rerun (since GitHub Actions doesn't allow users without write access to rerun CI jobs whose workflows are triggered by the If for any reason this change has to be undone, that can be achieved by force-pushing the branch back to 4ee51e3, where it was before. I've noticed that |
I feel like this PR has taken enough maintenance time as is and would appreciate if no more lines would be added to it.As initial verdict: it seems bloated for what it tries to accomplish and the original author of |
Thanks @EliahKagan for cleaning up the empty commit and reruns. |
What
Add CLI support in
gix blame
:--ignore-rev <REV>
(repeatable)--ignore-revs-file <PATH>
(multiple, unioned; comments/blank lines/BOM/CRLF handled)Why
Parity with
git blame --ignore-rev
, enabling users to exclude formatting/refactor commits when attributing lines. Tracks #2064.How
HashSet<ObjectId>
(de-duplicated).Verification
Manual matrix (all green):
git blame --ignore-rev
.Repro script excerpt:
Compatibility
AI Disclosure
AI-Assisted: Claude Code
Agent Mode: No (no autonomous actions)
Multi-line Completions: Yes — some suggestions were pasted, then edited and reviewed by me
all code human-edited and verified with clippy & the test suite