Reduce noise in gix-blame
tests
#2156
Merged
+66
−272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that reduces noise in
gix-blame
tests by implementingFrom<(Range<u32>, ObjectId)> for UnblamedHunk
. This implementation allows us to replaceUnblamedHunk { range_in_blamed_file: 3..5, suspects: [(suspect, 3..5)].into(), source_file_name: None, }
by(3..5, suspect).into()
andnew_unblamed_hunk(0..5, suspect, Offset::Added(0))
by(0..5, suspect).into()
. I think this change significantly increases the signal-to-noise ratio.In addition to this, we could also implement
From<(Range<u32>, (ObjectId, Range<u32>))> for UnblamedHunk
orFrom<(Range<u32>, ObjectId, Offset)> for UnblamedHunk
in order to convert places where the range associated with a suspect is not identical torange_in_blamed_file
, but the benefit would be smaller. What do you think?