chore: add check for closed connector #1269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._loop.call_soon_threadsafe(self._loop.stop) | ||
| # wait for thread to finish closing (i.e. loop to stop) | ||
| self._thread.join() | ||
| self._closed = True |
Collaborator
There was a problem hiding this comment.
this is not necessary as synchronous close calls close_async so should get closed by close_async
kgala2
force-pushed
the
error-on-closed-connection
branch
from
2629802 to
b8bc912
Compare
hessjcg
reviewed
Nov 4, 2025
| await asyncio.gather(*[cache.close() for cache in self._cache.values()]) | ||
| if self._client: | ||
| await self._client.close() | ||
| self._closed = True |
Collaborator
There was a problem hiding this comment.
Do this first, then client.close(), then gather cache.close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft-PR to check if the connector's been closed before trying to connect using the same engine.