fix(airflow_db_cleanup): removing additional "None" iteration upon Da…

[Bechamelle]

Description

Fixes #13569

Checklist

• Please merge this PR for me once it is approved

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @Bechamelle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor bug within the Airflow database cleanup script. It refines the DagRun cleaning process by eliminating an erroneous iteration over a None value, which could lead to unexpected behavior or inefficient processing. The change ensures that only valid DAG IDs are processed during the cleanup operation, improving the robustness of the script.

Highlights

• DagRun Cleaning Logic: Removed an unnecessary iteration over None in the list_dags variable during the airflow_db_cleanup process, preventing potential issues or redundant processing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in the Airflow database cleanup DAG by removing an extra iteration that was being performed with a None DAG ID. This iteration was redundant and could lead to incorrect behavior, especially for DagRun cleanup. The change is correct and improves the reliability of the cleanup process. I've added one suggestion to improve the readability and efficiency of the list comprehension used to gather DAG IDs.

[gemini-code-assist]

While this change correctly removes the redundant None iteration, the list comprehension can be made more efficient and readable. The dags query returns an iterable of tuple-like Row objects. You can access the first element directly using index [0] instead of converting each row to a list first. This avoids creating an unnecessary intermediate list for each DAG.

Suggested change

	list_dags = [str(list(dag)[0]) for dag in dags]
	list_dags = [str(dag[0]) for dag in dags]