Skip to content

feat: Add spacing method options to Repeat and Circular Repeat nodes #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
a-khushal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add spacing method options to Repeat and Circular Repeat nodes #3389

a-khushal wants to merge 1 commit into from
+129 −9

Conversation

@a-khushal
Copy link

@a-khushal a-khushal commented Nov 16, 2025 •
edited
Loading

Closes #2551
image

@Keavon

@a-khushal a-khushal marked this pull request as ready for review November 29, 2025 07:58
@Keavon
Copy link
Member

Keavon commented Nov 29, 2025

!build

@github-actions
Copy link

github-actions bot commented Nov 29, 2025

📦 Build Complete for 16f4922
https://94ab8d03.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Nov 29, 2025

"Width" is not supposed to be a parameter.

@a-khushal a-khushal force-pushed the repeat-spacing branch 4 times, most recently from 658e348 to 2ab55ec Compare November 30, 2025 13:41
@a-khushal
Copy link
Author

a-khushal commented Nov 30, 2025

@Keavon can you please review this now?

@Keavon
Copy link
Member

Keavon commented Nov 30, 2025

!build

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

📦 Build Complete for 2ab55ec
https://33d7c766.graphite.pages.dev

@a-khushal
Copy link
Author

a-khushal commented Dec 6, 2025

Hi @Keavon, any updates on the review when you get a moment?

@Ezbaze
Copy link
Contributor

Ezbaze commented Dec 12, 2025 •
edited by Keavon
Loading

Repeat Node

Span, Pitch, and Gap work as intended.

Envelope does not. The initial shape should remain in the same position, but Envelope mode currently shifts it. See below for details:

The orange dot at (0, 0) marks the canvas center, and in both examples the rectangle starts centered on the canvas.
Current:
Current

Expected:
Expected

File (rename to .graphite):
pr3389-Repeat.txt

Circular Repeat Node

This PR breaks the Circular Repeat node.

The Repeat node uses Direction to define spacing, but Circular Repeat previously distributed instances evenly around the circle by default. This PR doesn’t account for that original behavior.

Video:

pr3389-circular_repeat.mp4

File (rename to .graphite):
pr3389-Circular_Repeat.txt

CC @Keavon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add options to the 'Repeat' node for the spacing with envelope/span/pitch/gap

3 participants

@a-khushal @Keavon @Ezbaze