Skip to content

Include single connected points as extrema in the extrude node #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0HyperCube wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include single connected points as extrema in the extrude node #3469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
border: 4px solid #eee;
border-color: #eee transparent #eee transparent;
animation: spinning-loading-indicator 1s linear infinite;

@media (prefers-reduced-motion) {
animation: none;
content: "Loading…";
border: none;
}
}

@keyframes spinning-loading-indicator {
Expand Down
3 changes: 2 additions & 1 deletion node-graph/nodes/vector/src/vector_nodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,8 @@ pub mod extrude_algorithms {

let mut next_segment = vector.segment_domain.next_id();
for (index, &point) in points.iter().enumerate().take(first_half_points) {
if point != Found::Both {
// Extrema are single connected points or points with both psotive and negative values
if !matches!(point, Found::Both | Found::Positive | Found::Negative) {
continue;
}

Expand Down
Loading