-
Notifications
You must be signed in to change notification settings - Fork 163
[WIP] On-the-fly full simulation tagging #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Next steps are not straight forward. Unfortunately, we can not simply change the input collection names but have some mismatches. E.g. the retrieval of pfcand_dxy:
Unfortunately, this issue repeats over all the code for flavor-tagging input variables retrieval. The code in FCCAnalyses also repeats itself quite often and could be shortened. Maybe then, it would be easier to change to full simulation. Maybe, there is an other work-around I don't see right now. |
|
I have managed to make it run. For an example, use e.g. the histmaker of the the Hgamma analysis here. You will see that it runs though but if I look at the b-jet scores of gammabb ( They should beek at 2 and they don't... Next steps to debug:
General remark: to have an extra retrieval of the input variables here in FCCAnalyses will make the tagger prone to errors because if the retrievals do not match then the performance is worse. But as far as I am aware there is no workaround? |
|
I've implemented the same PID retrieval as used in CLDConfig and implemented the usage of the reco PV. Unfortunetly, the jet clustering defintion in FCCAnalyses and key4hep/CLDConfig (which the tagger was trained on) differ a lot, see this CLDConfig issue. Next possible step: One could use data with jets already clustered in CLDConfig and use the inference in FCCAnalyses to check if the inference is correctly implemented in FCCAnlayses. To have both, jet clustering and tagging, implemented on-the-fly in FCCAnlayses in full simulation, one must first agree on a common jet clustering definition. |

Add on-the-fly full simulation tagging to FCCAnalyses master.