Skip to content

Conversation

@kreczko
Copy link
Member

@kreczko kreczko commented Jul 27, 2020

No description provided.

@kreczko
Copy link
Member Author

kreczko commented Jul 27, 2020

@fschaer any objections to these changes?
The most relevant one is 30ddd75 which is a rewrite of the randompass function in modern Ruby

@fschaer
Copy link

fschaer commented Jul 27, 2020 via email

@kreczko kreczko force-pushed the kreczko-version-1.0.0-prep branch from a9cb4e1 to 8fd23cd Compare July 27, 2020 15:14
@kreczko
Copy link
Member Author

kreczko commented Jul 27, 2020

Thanks for the quick reply. Params is only used in argus::servicecert it seems, so easy to remove - done in 8fd23cd.

As for the params change: that changed from params to argus::params for the servicecert in your PR. Sorry, missed that one too :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants