This repository was archived by the owner on Oct 14, 2025. It is now read-only.
generated from HackYourFuture-CPH/hyf-assignment-template
-
Notifications
You must be signed in to change notification settings - Fork 64
React 1/week2 #45
Open
GuzideGuzelbey
wants to merge
2
commits into
HackYourFuture-CPH:main
Choose a base branch
from
GuzideGuzelbey:react-1/week2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
React 1/week2 #45
GuzideGuzelbey
wants to merge
2
commits into
HackYourFuture-CPH:main
from
GuzideGuzelbey:react-1/week2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desafree
reviewed
Apr 10, 2025
| let numberOfPlanets = 0; | ||
| const [planets, setPlanets] = useState(planetData); | ||
| const selectedPlanets = planets.filter((planet) => planet.isSelected); | ||
| const numberOfPlanets = selectedPlanets.length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job using the derived state here!
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
desafree
reviewed
Apr 10, 2025
| </section> | ||
| <section className="card"> | ||
| <h2>Possible destinations</h2> | ||
| {planets.map((planet) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job using map here!
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again :)
|
Nice job on focusing on the style as well 🫡 |
Author
|
I wish I had more time to work on responsiveness, but could not. Thank you for your time :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess I will focus on responsiveness this week. I couldn't focus on that functionality yet.
Thank you in advance:)
note: Please consider only this commit f1b8941