Test enhancement

.travis.yml

@@ -12,6 +12,9 @@ php:
     - 5.6
     - 7.0
     - 7.1
+    - 7.2
+    - 7.3
+    - 7.4
 env:
   global:
     - TEST_COMMAND="composer test"

src/Api/HttpApi.php

@@ -58,11 +58,11 @@ protected function hydrateResponse(ResponseInterface $response, $class)
             return $response;
         }
 
-        if ($response->getStatusCode() === 204) {
+        if (204 === $response->getStatusCode()) {
             return null;
         }
 
-        if ($response->getStatusCode() !== 200 && $response->getStatusCode() !== 201) {
+        if (200 !== $response->getStatusCode() && 201 !== $response->getStatusCode()) {
             $this->handleErrors($response);
         }
 

src/Api/UserManagement.php

@@ -45,6 +45,7 @@ public function update($user, $param)
 
         return $this->hydrateResponse($response, User::class);
     }
+
     /**
      * @param string $user the user ID we should merge personality data to.
      * @param string $from the user ID we should merge personality data from.

src/Exception/Domain/HttpClientException.php

@@ -32,7 +32,7 @@ public function __construct($message, $code, ResponseInterface $response = null)
         if ($response) {
             $this->response = $response;
             $body = $response->getBody()->__toString();
-            if (strpos($response->getHeaderLine('Content-Type'), 'application/json') !== 0) {
+            if (0 !== strpos($response->getHeaderLine('Content-Type'), 'application/json')) {
                 $this->responseBody['message'] = $body;
             } else {
                 $this->responseBody = json_decode($body, true);

src/Hydrator/ArrayHydrator.php

@@ -21,7 +21,7 @@ final class ArrayHydrator implements Hydrator
     public function hydrate(ResponseInterface $response, $class)
     {
         $body = $response->getBody()->__toString();
-        if (strpos($response->getHeaderLine('Content-Type'), 'application/json') !== 0) {
+        if (0 !== strpos($response->getHeaderLine('Content-Type'), 'application/json')) {
             throw new HydrationException('The ArrayHydrator cannot hydrate response with Content-Type:'.$response->getHeaderLine('Content-Type'));
         }
 

src/Hydrator/ModelHydrator.php

@@ -22,7 +22,7 @@ final class ModelHydrator implements Hydrator
     public function hydrate(ResponseInterface $response, $class)
     {
         $body = $response->getBody()->__toString();
-        if (strpos($response->getHeaderLine('Content-Type'), 'application/json') !== 0) {
+        if (0 !== strpos($response->getHeaderLine('Content-Type'), 'application/json')) {
             throw new HydrationException('The ModelHydrator cannot hydrate response with Content-Type:'.$response->getHeaderLine('Content-Type'));
         }
 

src/Model/Statement/Statement.php

@@ -10,8 +10,11 @@
 final class Statement implements CreatableFromArray
 {
     const TYPE_STRING = 'string';
+
     const TYPE_IMAGE = 'image';
+
     const SECTION_PERSONALITY = 'personality';
+
     const SECTION_INTELLIGENCE = 'intelligence';
 
     /**

src/Model/UserManagement/User.php

@@ -38,7 +38,7 @@ public static function createFromArray(array $data)
     {
         $data = $data['data'];
 
-        return new self(isset($data['name']) ? $data['name']: '', $data['email']);
+        return new self(isset($data['name']) ? $data['name'] : '', $data['email']);
     }
 
     /**

tests/HttpClientConfiguratorTest.php

@@ -5,8 +5,9 @@
 use Happyr\ApiClient\HttpClientConfigurator;
 use Http\Client\Common\Plugin\HeaderAppendPlugin;
 use Nyholm\NSA;
+use PHPUnit\Framework\TestCase;
 
-final class HttpClientConfiguratorTest extends \PHPUnit_Framework_TestCase
+final class HttpClientConfiguratorTest extends TestCase
 {
     public function testAppendPlugin()
     {