-
Notifications
You must be signed in to change notification settings - Fork 8
Add Core zFPKM Tests #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Core zFPKM Tests #239
Conversation
…dicates an incorrect taxon id Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
…ht across the study Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
…sible Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
BREAKING-CHANGE: instead of providing a type `PeakIdentificationParameters`, simply provide the min peak height and distance directly Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
…sible Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
…sible Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
…ecting gene data Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the codebase by replacing NumPy-specific float types (like np.float64, np.float32, np.int8) with Python's built-in float and int types. Key changes include:
- Replacing NumPy-specific dtype specifications with Python built-ins
- Adding new utility functions for kernel density estimation (
density.py,approx.py,peak_finder.py) - Updating type annotations to use
floatandintinstead of NumPy types - Adding a type checker configuration file (
ty.toml) - Improving gene data handling and conversions
- Various code quality improvements and refactoring
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| ty.toml | Adds type checker configuration |
| tests/unit/*.py | New comprehensive test files for density, approx, and peak_finder modules |
| tests/unit/test_*.py | Updates dtype specifications from np.float32/int8 to built-in float/int |
| main/como/utils.py | Adds itertools import, improves type annotations and error handling |
| main/como/stats/*.py | Replaces np.float64 with float in type annotations |
| main/como/rnaseq_*.py | Major refactoring: replaces scipy/sklearn with custom R-compatible implementations |
| main/como/data_types.py | Updates Enum values to lowercase, adds defaults to PeakIdentificationParameters |
| main/como/density.py | New module implementing R's density function |
| main/como/approx.py | New module implementing R's approx function |
| main/como/peak_finder.py | New module implementing R's findpeaks function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request adds unit tests to: