Skip to content

Conversation

@JoshLoecker
Copy link
Member

This pull request adds unit tests to:

  • density calculation
  • peak finding
  • interpolation

…dicates an incorrect taxon id

Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
BREAKING-CHANGE: instead of providing a type `PeakIdentificationParameters`,  simply provide the min peak height and distance directly
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Copilot AI review requested due to automatic review settings November 3, 2025 20:21
@JoshLoecker JoshLoecker changed the base branch from main to develop November 3, 2025 20:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by replacing NumPy-specific float types (like np.float64, np.float32, np.int8) with Python's built-in float and int types. Key changes include:

  • Replacing NumPy-specific dtype specifications with Python built-ins
  • Adding new utility functions for kernel density estimation (density.py, approx.py, peak_finder.py)
  • Updating type annotations to use float and int instead of NumPy types
  • Adding a type checker configuration file (ty.toml)
  • Improving gene data handling and conversions
  • Various code quality improvements and refactoring

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
ty.toml Adds type checker configuration
tests/unit/*.py New comprehensive test files for density, approx, and peak_finder modules
tests/unit/test_*.py Updates dtype specifications from np.float32/int8 to built-in float/int
main/como/utils.py Adds itertools import, improves type annotations and error handling
main/como/stats/*.py Replaces np.float64 with float in type annotations
main/como/rnaseq_*.py Major refactoring: replaces scipy/sklearn with custom R-compatible implementations
main/como/data_types.py Updates Enum values to lowercase, adds defaults to PeakIdentificationParameters
main/como/density.py New module implementing R's density function
main/como/approx.py New module implementing R's approx function
main/como/peak_finder.py New module implementing R's findpeaks function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JoshLoecker JoshLoecker review requested due to automatic review settings November 3, 2025 20:25
@JoshLoecker JoshLoecker merged commit 69697bc into develop Nov 3, 2025
3 checks passed
@JoshLoecker JoshLoecker deleted the zfpkm-tests branch November 3, 2025 20:26
JoshLoecker added a commit that referenced this pull request Nov 3, 2025
JoshLoecker added a commit that referenced this pull request Nov 3, 2025
JoshLoecker added a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants