impr + fix/migrations, embedding macro, optional paramas #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into lazy-migrations
…lix-db into builtin-endpoints
…into builtin-endpoints + fix issues with handling macros
## Description
<!-- Provide a brief description of the changes in this PR -->
adding optional params to hql
defined by `?` just like in type script
e.g.
```js
QUERY (username?: String) =>
....
```
## Related Issues
<!-- Link to any related issues using #issue_number -->
Closes #
## Checklist when merging to main
<!-- Mark items with "x" when completed -->
- [ ] No compiler warnings (if applicable)
- [ ] Code is formatted with `rustfmt`
- [ ] No useless or dead code (if applicable)
- [ ] Code is easy to understand
- [ ] Doc comments are used for all functions, enums, structs, and
fields (where appropriate)
- [ ] All tests pass
- [ ] Performance has not regressed (assuming change was not to fix a
bug)
- [ ] Version number has been updated in `helix-cli/Cargo.toml` and
`helixdb/Cargo.toml`
- [ ] Lines are kept under 100 characters where possible
- [ ] Code is good
## Additional Notes
<!-- Add any additional information that would be helpful for reviewers
-->
…rom id (#325) ## Description <!-- Provide a brief description of the changes in this PR --> added v from id merging migration hql syntax and rust generation and internal implementation fixing updating and deleting secondary indexes ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
## Description <!-- Provide a brief description of the changes in this PR --> ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
There was a problem hiding this comment.
Pull Request Overview
This PR implements improvements to migrations, adds an embedding macro for model annotations, and introduces optional parameter functionality. The changes enhance the framework's ability to handle schema evolution, model integration, and flexible API design.
Key changes:
- Implementation of migration functionality with schema versioning support
- Addition of embedding macro for annotating queries with model information
- Optional parameter support in query functions
- Enhanced type casting and value conversion capabilities
Reviewed Changes
Copilot reviewed 64 out of 65 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| hql-tests/file59/schema.hx | Migrated from commented schema to explicit versioned schemas with migration definition |
| hql-tests/file57/schema.hx | Added vector-based clinical note schema definition |
| hql-tests/file57/file57.hx | Implemented embedding-annotated queries for clinical note operations |
| hql-tests/file56/output.json | Removed large JSON output file content |
| hql-tests/file56/file56.hx | Added optional parameter support to search query |
| hql-tests/file51/schema.hx | Expanded schema with user relationships and versioning |
| hql-tests/file51/migrations.hx | Added migration definition between schema versions |
| helix-macros/src/lib.rs | Implemented migration macro for schema transition handling |
| helix-db/src/utils/items.rs | Added version field to Node and Edge structs |
| helix-db/src/utils/id.rs | Enhanced ID type with additional conversion methods |
| helix-db/src/protocol/value.rs | Extensive type casting and value conversion improvements |
| helix-db/src/protocol/date.rs | Added error handling for date operations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrations, embedding macro, optional paramas
Related Issues
Closes #
Checklist when merging to main
rustfmthelix-cli/Cargo.tomlandhelixdb/Cargo.tomlAdditional Notes