Legacy code unification with mainline. #28
Draft
+10,090
−1,663,062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `TypeGenerationStep.cs`, refactored pointer and handle type management by introducing new `StringBuilder` instances for better clarity and error handling. The logic for adding to `WrappedPointers` now includes error logging for conflicts, ensuring existing mappings are not overwritten. In `HexaGen.csproj`, updated the `PackageId` to `HexaGen.Legacy` and changed the `PackageVersion` from `1.1.10` to `1.0.0`. Added an `ItemGroup` to include `LICENSE.txt` and `README.md` for packaging.
Bump the `PackageVersion` in `HexaGen.csproj` from `1.0.0` to `1.0.1`.
Updated the codebase to use Newtonsoft.Json instead of System.Text.Json for JSON serialization across multiple files. Incremented the PackageVersion in HexaGen.Core.csproj to 1.1.4.1 and added a reference to Newtonsoft.Json version 13.0.3. Refactored the BaseGenerator class for improved configuration handling and introduced a new CollectionNormalizer class to ensure proper initialization of collections. Enhanced CsCodeGeneratorConfig with new properties and methods for better management. Added the GeneratorBuilder class to streamline code generation setup and included new classes/interfaces like IConfigComposer, ImportType, and MergeOptions to support the new functionality. Created a new TestApp project with a Program.cs entry point for testing, along with sample configuration files config.base.json and config.json for easier demonstration of features.
- Modified `WriteConstructors` and `WriteConstructor` methods to include properties instead of fields. - Introduced `targetsProperty` boolean to enhance parameter handling. - Updated constructor logic for new property checks. - Incremented `PackageVersion` in `HexaGen.csproj` from 1.0.6 to 1.0.7. - Replaced `Foo` enum with boolean fields in `Test` struct in `Foo.cs`. - Adjusted `Test` struct constructor to accommodate new boolean fields. - Reformatted `TestApp.csproj` for consistent XML structure. - Updated `main.h` to reflect changes in the `Test` struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.