Skip to content

When code signing, a connection to the Apple time servers is required. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

When code signing, a connection to the Apple time servers is required. #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d563ad
When code signing, a connection to the Apple time servers is required.
digitalmoksha Jan 2, 2017
55b1a47
Default `codesign_disable_timestamp` to true when in development
digitalmoksha Jan 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/motion/project/template/osx/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def codesign_bundle(config, bundle, deep = false)
command = "/usr/bin/codesign --force --sign '#{config.codesign_certificate}' "
command << "--deep " if deep
command << "--entitlements '#{entitlements_path}' " if entitlements_path
command << "--timestamp=none " if config.codesign_disable_timestamp
command << "'#{bundle}'"
sh(command)
end
Expand Down
3 changes: 2 additions & 1 deletion lib/motion/project/xcode_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module Motion; module Project
class XcodeConfig < Config
variable :xcode_dir, :sdk_version, :deployment_target, :frameworks,
:weak_frameworks, :embedded_frameworks, :external_frameworks, :framework_search_paths,
:libs, :identifier, :codesign_certificate, :short_version, :entitlements, :delegate_class, :embed_dsym,
:libs, :identifier, :codesign_certificate, :codesign_disable_timestamp, :short_version, :entitlements, :delegate_class, :embed_dsym,
:version

def initialize(project_dir, build_mode)
Expand All @@ -53,6 +53,7 @@ def initialize(project_dir, build_mode)
@embed_dsym = (development? ? true : false)
@vendor_projects = []
@version = '1.0'
@codesign_disable_timestamp = (development? ? true : false)
end

def xcode_dir=(xcode_dir)
Expand Down