DEV-401 Implement commentService.ts #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
issacli-0821
requested changes
Dec 4, 2025
frontend/api/commentService.ts
Outdated
| export async function createNewComment(): Promise<Comment | null> { | ||
| // POST answers/{answerId}/comments/ | ||
| return null; | ||
| export async function getAllComments(answerId: string | number): Promise<Comment[] | null> { |
Contributor
There was a problem hiding this comment.
We can treat answerId as a string
| } | ||
|
|
||
| export async function updateCommentDetails(commentId: string): Promise<Comment | null> { | ||
| type UpdateCommentPayload = Partial<Pick<Comment, 'text' | 'is_anonymous' | 'hearts'>>; |
Contributor
There was a problem hiding this comment.
We can just make the payload a type with all the fields for a comment for now
frontend/api/commentService.ts
Outdated
| export async function getAllComments(): Promise<Comment[] | null> { | ||
| // GET answers/{answerId}/comments/ | ||
| return null; | ||
| async function parseComment(res: Response): Promise<Comment | null> { |
Contributor
There was a problem hiding this comment.
Not sure if these parsing functions are needed since they are pretty self explanatory and might make more sense within the functions. We also don't need the check for 204 since that's for empty response, which should only happen for delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes