Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

fix: Modified to adapt horizontally long images. #1349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koreander2001
Copy link

@koreander2001 koreander2001 commented May 4, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Frontend

Describe the reason for change

In a horizontally long image, the area visible is narrow when zoomed in.

What does this fix?

The default value of maxheight is set to the default value of height.

What is the new behavior?

2023-05-04.185321.edited.mp4

What is the current behavior?

2023-05-04.184949.edited.mp4

What libraries were added/updated?

No libraries.

Does this change affect performance?

Maybe no.

Does this change affect security?

No.

What alternative approaches were there?

Maybe no.

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Pages that be able to zoom in on images.

@github-actions github-actions bot added the fix label May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant