fix: Changed union typing in client_ext.py from | operator to Union[] for compatibility with Python 3.9 #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced | operator for union typing, which only works since Python 3.10, with Union[] typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current release, this package doesnt work in Python 3.9 if you try to "from label_studio_sdk import Client", because of 2 functions definitions in client_ext.py that use the | operator for union typing, a feature that only works since Python 3.10 (https://peps.python.org/pep-0604/).
I replaced the | operator for union typing with Union[] typing, in 2 instances in client_ext.py.