fix: Replace surrogate characters before rendering #7871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a crash issue in base.html rendering when a git commit message includes surrogate characters, such as emojis (e.g., 🐛).
The root cause was traced to the
json_dumps_ensure_ascii
function, which does not properly handle surrogate pairs, leading to aUnicodeEncodeError
during template rendering.So I added a preprocessing step to replace or safely handle surrogate characters before they reach the JSON encoder, ensuring that the response can be encoded in UTF-8 without failure.
While there's currently no use of emojis in commit messages, this fix can prevent potential future errors in case such characters comes up someday.