feat: FIT-529: Convert main menu to an icon menu in LSO #8151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8151 +/- ##
===========================================
- Coverage 70.49% 70.48% -0.02%
===========================================
Files 720 720
Lines 52128 52129 +1
Branches 8813 8813
===========================================
- Hits 36748 36743 -5
- Misses 15377 15383 +6
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "icon menu" feature, controlled by the
fflag_feat_fit_528_icon_menu_shortfeature flag. When enabled, the sidebar menu switches to a compact, icon-only style with tooltips and adjusted styling. The changes span backend templates, frontend React components, and SCSS styles to support this new mode.Feature flag integration and backend template changes:
fflag_feat_fit_528_icon_menu_shortinbase.html,simple.html, andindex.htmlto conditionally add a CSS class to the<body>element, enabling icon menu support. [1] [2] [3]FF_ICON_MENUconstant in the feature flags definitions.Sidebar and menu component updates:
Menubarcomponent to detect the icon menu flag and, when enabled, render menu items with tooltips, remove text labels, and adjust spacers/dividers for a more compact layout. [1] [2] [3]MenuItemcomponent to conditionally wrap items in a tooltip and display only the icon when in icon menu mode. [1] [2] [3] [4] [5]Styling and layout adjustments:
--icon-menu-widthCSS variable and adjusted the sidebar width and styling when icon menu mode is active, including menu item alignment, padding, and background. [1] [2] [3]