-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: FIT-771: Display name of project being deleted on Danger Zone confirmation dialogs #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8623 +/- ##
===========================================
- Coverage 66.81% 60.08% -6.73%
===========================================
Files 786 548 -238
Lines 60311 38772 -21539
Branches 10254 10254
===========================================
- Hits 40297 23298 -16999
+ Misses 20011 15471 -4540
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@bmartel do you mind accepting this one too? I ported the suggested fixes over. |
/git merge
|
/git merge
|
/git merge
|
This pull request refactors the Danger Zone settings page and updates modal styling for consistency. The main focus is on improving the user experience and accessibility of dangerous actions (like deleting a project) by introducing a confirmation modal that requires explicit user input, and by standardizing modal padding across the app.
Screenshots
Before
After
Danger Zone UI/UX improvements:
Typography
components for headings and descriptions, improving readability and visual consistency. [1] [2]Modal styling consistency:
Modal.scss
files to use CSS variables (--spacing-base
,--spacing-wider
) for consistent spacing across the app. [1] [2]datamanager
to use CSS variables for improved maintainability and consistency.