Skip to content

Conversation

ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Oct 9, 2025

This pull request refactors the Danger Zone settings page and updates modal styling for consistency. The main focus is on improving the user experience and accessibility of dangerous actions (like deleting a project) by introducing a confirmation modal that requires explicit user input, and by standardizing modal padding across the app.

Screenshots

Before

image image

After

image image image image image

Danger Zone UI/UX improvements:

  • Replaced the old confirmation dialog with a custom modal that requires users to type a specific word before proceeding with dangerous actions (reset cache, drop tabs, delete project). This makes destructive actions safer and more deliberate.
  • Added toast notifications to inform users of the success or failure of each dangerous action.
  • Updated the Danger Zone page to use Typography components for headings and descriptions, improving readability and visual consistency. [1] [2]

Modal styling consistency:

  • Standardized modal footer and header padding in both Modal.scss files to use CSS variables (--spacing-base, --spacing-wider) for consistent spacing across the app. [1] [2]
  • Updated modal body padding in datamanager to use CSS variables for improved maintainability and consistency.

Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit e5af823
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68ececa8db8cc300084b311b

Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit e5af823
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68ececaa5513e0000867ec8a

Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit e5af823
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68ececa8ae5f320008220b06
😎 Deploy Preview https://deploy-preview-8623--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Oct 9, 2025
@ricardoantoniocm ricardoantoniocm self-assigned this Oct 9, 2025
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit e5af823
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68ececa8d2f16f000873f435
😎 Deploy Preview https://deploy-preview-8623--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.08%. Comparing base (c551c4b) to head (e5af823).
⚠️ Report is 1 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (c551c4b) and HEAD (e5af823). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c551c4b) HEAD (e5af823)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8623      +/-   ##
===========================================
- Coverage    66.81%   60.08%   -6.73%     
===========================================
  Files          786      548     -238     
  Lines        60311    38772   -21539     
  Branches     10254    10254              
===========================================
- Hits         40297    23298   -16999     
+ Misses       20011    15471    -4540     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 54.35% <ø> (+1.33%) ⬆️
lsf-integration 50.87% <ø> (ø)
lsf-unit 8.59% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm
Copy link
Contributor Author

@bmartel do you mind accepting this one too? I ported the suggested fixes over.

@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review October 9, 2025 21:53
@ricardoantoniocm ricardoantoniocm requested a review from a team as a code owner October 9, 2025 21:53
@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 10, 2025

/git merge

Workflow run
Successfully merged: 6 files changed, 46 insertions(+), 16 deletions(-)

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 10, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/core/src/providers/api-provider.tsx

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 13, 2025

/git merge

Workflow run
Successfully merged: 2 files changed, 55 insertions(+), 1 deletion(-)

@robot-ci-heartex robot-ci-heartex merged commit b3b971b into develop Oct 13, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-771 branch October 13, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants