-
Notifications
You must be signed in to change notification settings - Fork 0
Implement --ignore-unmatched for uploading results #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds --ignore-unmatched option that shows only a summary (e.g. 'Skipped 2 unmatched tests') instead of individual error messages for unmatched tests. Useful during gradual test case library migration to reduce CI log noise.
Refactored extractTestCaseRefs() with shouldFailOnInvalid flag and early returns for better readability.
Summary of ChangesHello @AndrianBdn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the test result upload functionality by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the --ignore-unmatched flag, a valuable feature for users gradually integrating their tests. The implementation is robust, complete with updated documentation and new tests ensuring the feature's correctness. The refactoring within ResultUploader.ts is a notable improvement, enhancing code readability and maintainability by decomposing a large method into smaller, single-responsibility functions. The logic correctly handles the new flag for both creating new test runs and updating existing ones. Overall, this is a high-quality contribution.
Some users are adding tests gradually and they see a lot of unmatched tests. Normally they result a failure; which could be overridden with "force". However "force" sounds a bit scary and it still leaves lot of noise in logs.
Hence this PR introduces separate flag for ignoring unmatched test cases, when uploading reports.
I've also took chance to slightly refactor some areas, by using early exists and moving console messages to separate functions.