Add support for creating test cases #39

hi-rai · 2025-12-19T14:45:23Z

This fixes https://github.com/Hypersequent/tms-issues/issues/2141

gemini-code-assist · 2025-12-19T14:45:54Z

Summary of Changes

Hello @hi-rai, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test result upload commands (junit-upload and playwright-json-upload) by introducing the capability to automatically create test cases in QA Sphere for results that lack predefined markers. This feature, along with improved project code specification and updated API interactions, streamlines the integration of automated test results, making it easier to manage and map tests within the QA Sphere platform. The changes aim to provide greater flexibility and reduce manual effort in setting up test case tracking.

Highlights

Automatic Test Case Creation: Introduced a new --create-tcases option for the junit-upload and playwright-json-upload commands. When enabled, this option automatically creates new test cases in QA Sphere for any test results that do not have valid test case markers.
Test Case Mapping File Generation: Upon creating new test cases via --create-tcases, a mapping file (qasphere-automapping-YYYYMMDD-HHmmss.txt) is generated. This file lists the sequence numbers assigned to each newly created test case, helping users update their test suites for future uploads.
Explicit Project Code Specification: Added a --project-code option to explicitly specify the project code when creating a new test run. This provides a more reliable alternative to auto-detecting the project code from test case names, which can be unreliable.
API Enhancements: Implemented new API endpoints and schemas for paginated retrieval of test cases and bulk creation of test cases, supporting the new automatic test case creation functionality.
Documentation and Examples Update: The README.md has been updated to reflect the new command-line options, clarify the two modes of uploading results (to an existing run or creating a new one), and provide updated examples for various scenarios, including automatic test case creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant enhancement to the junit-upload and playwright-json-upload commands, allowing users to automatically create new test cases in QA Sphere for results that lack valid markers. The README.md has been updated to clarify the two modes of operation (uploading to an existing run or creating a new one) and details the new --project-code and --create-tcases options, including examples and updated requirements for test case matching. Core API changes include new interfaces for pagination and test case creation (PaginatedResponse, TCase, CreateTCasesRequest, CreateTCasesResponse) in src/api/schemas.ts, and corresponding API methods (getTCasesPaginated, createTCases) in src/api/tcases.ts. A new utility appendSearchParams was added in src/api/utils.ts for building URL query parameters. The command-line interface in src/commands/resultUpload.ts now includes the --project-code and --create-tcases options, with revised examples and epilogue text. New test fixtures were added, and src/tests/result-upload.spec.ts was updated with new test cases and mocked API handlers to validate the test case creation functionality, including cleanup for generated mapping files. The ResultUploadCommandHandler in src/utils/result-upload/ResultUploadCommandHandler.ts was refactored to support the new modes, including a discriminated union for command arguments, logic for detecting project codes, fetching existing test cases, creating new ones, and generating a mapping file for newly created test cases. Review comments highlighted a type safety issue with the runName property in ResultUploadCommandArgs, an unsafe type assertion for runName in processTemplate, and a potential bug in the isValidValue utility function where 0 was incorrectly treated as an invalid value, suggesting a more robust check for null and undefined.

src/utils/result-upload/ResultUploadCommandHandler.ts

gemini-code-assist · 2025-12-19T14:49:01Z

src/api/utils.ts

+	const isValidValue = (value: unknown) => {
+		return value || value === false || value === ''
+	}


The isValidValue function currently filters out the number 0 because 0 is a falsy value. This could lead to unexpected behavior if an API parameter legitimately needs to be 0. A safer and clearer implementation would be to explicitly check for null and undefined.

Suggested change

const isValidValue = (value: unknown) => {

return value || value === false || value === ''

}

const isValidValue = (value: unknown) => {

return value !== null && value !== undefined

}

seems logical

src/utils/result-upload/ResultUploadCommandHandler.ts

…creation

satvik007

Great work!

satvik007 · 2025-12-30T16:29:36Z

src/api/tcases.ts

+			fetcher(`/api/public/v0/project/${projectCode}/tcase/seq`, {
+				method: 'POST',
+				body: JSON.stringify(request),
+			}).then((r) => jsonResponse<PaginatedResponse<TCase>>(r)),


We should add zod for validation in future.

satvik007 · 2025-12-31T08:39:59Z

src/api/utils.ts

+	const isValidValue = (value: unknown) => {
+		return value || value === false || value === ''
+	}


seems logical

satvik007 · 2025-12-31T08:47:28Z

src/utils/result-upload/ResultUploadCommandHandler.ts

-		const tcaseRefs = new Set<string>()
+	protected async getTCaseIds(projectCode: string, fileResults: FileResults[]) {
 		const shouldFailOnInvalid = !this.args.force && !this.args.ignoreUnmatched
+		const tcaseSeqRegex = new RegExp(`${projectCode}-(\\d{3,})`)


We can reduce false positives if we give priority to matches that start at the beginning or at the end somehow.

satvik007 · 2025-12-31T08:51:20Z

src/utils/result-upload/ResultUploadCommandHandler.ts

+			const response = await this.api.folders.getFoldersPaginated(projectCode, {
+				page,
+				limit: DEFAULT_PAGE_SIZE,
+			})
+


In future, We can introduce folder search by folder title. Right now we are overfetching

satvik007 · 2025-12-31T09:01:05Z

src/utils/result-upload/ResultUploadCommandHandler.ts

+			const mappingFilename = processTemplate(DEFAULT_MAPPING_FILENAME_TEMPLATE)
+			const mappingLines = tcases
+				.map((t, i) => `${getTCaseMarker(projectCode, t.seq)}: ${tcasesToCreate[i]}`)
+				.join('\n')


If we use this mapping file created via a previous use, we could avoid the step of fetching test cases from default folder and then matching the titles and all matches are found.

hi-rai requested review from AndrianBdn, ramilamparo, satvik007 and sirkostya009 December 19, 2025 14:45

hi-rai self-assigned this Dec 19, 2025

Add support for creating test cases

993ce44

hi-rai force-pushed the dev/himanshu/create-tcase-flag branch from dfe9d22 to 993ce44 Compare December 19, 2025 14:47

gemini-code-assist bot reviewed Dec 19, 2025

View reviewed changes

hi-rai commented Dec 19, 2025

View reviewed changes

src/utils/result-upload/ResultUploadCommandHandler.ts Outdated Show resolved Hide resolved

Fix comments

cd525f7

satvik007 added this to the 26W02 milestone Dec 22, 2025

hi-rai added 2 commits December 23, 2025 17:38

Use get tcase seq APIs, fetch tcases only from default folder during …

bd66a06

…creation

Merge remote-tracking branch 'origin/main' into create-tcase-flag

76c087d

satvik007 approved these changes Dec 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for creating test cases #39

Add support for creating test cases #39

Uh oh!

hi-rai commented Dec 19, 2025

Uh oh!

gemini-code-assist bot commented Dec 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Dec 19, 2025

Uh oh!

satvik007 Dec 31, 2025

Uh oh!

Uh oh!

satvik007 left a comment

Uh oh!

satvik007 Dec 30, 2025

Uh oh!

satvik007 Dec 31, 2025

Uh oh!

satvik007 Dec 31, 2025

Uh oh!

satvik007 Dec 31, 2025

Uh oh!

satvik007 Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add support for creating test cases #39

Are you sure you want to change the base?

Add support for creating test cases #39

Uh oh!

Conversation

hi-rai commented Dec 19, 2025

Uh oh!

gemini-code-assist bot commented Dec 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

satvik007 left a comment

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

satvik007 Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants