Skip to content

Change x-synthetic-trusted-server header to x-psid-ts #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change x-synthetic-trusted-server header to x-psid-ts #66

wants to merge 1 commit into from

Conversation

@ChristianPavilonis
Copy link
Collaborator

Closes #52

@ChristianPavilonis
Copy link
Collaborator Author

Based on the issue description it's ambiguous if we want to literally change the header names.
or do we mean to do something like this: #67 to make it configurable?

@jevansnyc
Copy link
Collaborator

No not configurable, consistent across all pubs for synthetic ID so literal header label:

x-psid-ts:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aram356 aram356 Awaiting requested review from aram356

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename headers for publisher IDs

2 participants

@ChristianPavilonis @jevansnyc