aws script to replace network interface for r7 instances #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizk886
changed the title
…/github.com/IABTechLab/uid2-operator into wzh-UID2-5843-auto-detect-network-interface
…/github.com/IABTechLab/uid2-operator into wzh-UID2-5843-auto-detect-network-interface
cYKatherine
reviewed
Dec 3, 2025
cYKatherine
reviewed
Dec 3, 2025
cYKatherine
reviewed
Dec 3, 2025
cYKatherine
reviewed
Dec 3, 2025
scripts/aws/ec2.py
Outdated
|
|
||
| # sockd -D daemonizes and returns immediately, but child process needs time to initialize | ||
| logging.info("Waiting for sockd to fully initialize...") | ||
| time.sleep(2) |
Contributor
There was a problem hiding this comment.
why 2? Is there any safer way to make sure the child processes have been initialised instead of relying on the random number
Contributor
Author
There was a problem hiding this comment.
I've determined that the intermittent issues I was experiencing were caused by enclave ID registration problems, which have now been resolved. As a result, I've removed the retry logic I had previously added, as it's no longer necessary with the root cause fixed :)
…/github.com/IABTechLab/uid2-operator into wzh-UID2-5843-auto-detect-network-interface
cYKatherine
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.