Skip to content

Fix for Snapshot restore of GDP-Scale PVC with 'G' units fails #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

shravaniphadolibm
Copy link
Contributor

Pull request checklist

CNSA issue no 8820

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature Enhancement
  • Test Automation
  • Code Refactoring (no functional changes, no api changes)
  • Build related changes
  • Community Operator listing
  • Other (please describe):

What is the current behavior?

  • Snapshot restoration fails for restore size greater than pvc size (decimal unit)

What is the new behavior?

  • Snapshot restore size is less than pvc capacity hence snapshot restoration is successful.

How risky is this change?

  • Small, isolated change
  • Medium, requires regression testing
  • Large, requires functional and regression testing

@shravaniphadolibm
Copy link
Contributor Author

shravaniphadolibm commented Jun 9, 2025

Image for testing : quay.io/shravanired123/ibm-spectrum-scale-csi-driver:10junetest2

@shravaniphadolibm shravaniphadolibm changed the title [WIP] Fix for Snapshot restore of GDP-Scale PVC with 'G' units fails Fix for Snapshot restore of GDP-Scale PVC with 'G' units fails Jun 9, 2025
@badri-pathak
Copy link
Member

@shravaniphadolibm DCO action is required. You have to perform signed git commit.
Here is the example to perform signed commit. Please check it once.
Ref: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

git commit -S -m "YOUR_COMMIT_MESSAGE"

@badri-pathak badri-pathak added this to the v2.14.1 milestone Jun 10, 2025
badri-pathak
badri-pathak previously approved these changes Jun 11, 2025
Copy link
Member

@deeghuge deeghuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have check in function IfSameVolReqInProcess(). We have to make sure this change is not breaking that check.

@Jainbrt Jainbrt modified the milestones: v2.14.1, v2.14.2 Jun 13, 2025
@Jainbrt Jainbrt requested a review from deeghuge June 25, 2025 01:38
@Jainbrt Jainbrt dismissed deeghuge’s stale review June 25, 2025 01:39

@deeghuge, could you please re-review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants