config map changes for primaryfs removal #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “hemalathagajendran” <“[email protected]”>
hemalathagajendran
changed the title
added 2 commits
August 12, 2025 02:46
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Signed-off-by: “hemalathagajendran” <“[email protected]”>
hemalathagajendran
changed the title
added 5 commits
August 13, 2025 00:28
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Signed-off-by: “hemalathagajendran” <“[email protected]”>
Jainbrt
previously approved these changes
Aug 14, 2025
| # inodeLimit: "< inode limit for Primary Fileset >" # Optional | ||
| # remoteCluster: "< Remote ClusterID >" # Optional - This is only required if primaryFs is remote cluster's filesystem and this ID should have separate entry in Clusters map too. | ||
| # cacert: "< Name of CA cert configmap for GUI >" # Optional | ||
| # cacert: "< Name of CA cert configmap for GUI >" # Optional |
There was a problem hiding this comment.
I think this cacert line shouldn't be changed
There was a problem hiding this comment.
undone the alignment change
Signed-off-by: “hemalathagajendran” <“[email protected]”>
| @@ -28,11 +28,6 @@ spec: | |||
| - id: "<Primary Cluster ID>" | |||
There was a problem hiding this comment.
It’s better to avoid using the term Primary Cluster ID at both the places; instead, use Local Scale ClusterID.
There was a problem hiding this comment.
Basically given as such so that user should give the same primary cluster id in localScaleCluster as well
badri-pathak
approved these changes
Aug 14, 2025
badri-pathak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the type of change your PR introduces:
How risky is this change?