Skip to content

fix(helm): remove legacy migration job and references #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): remove legacy migration job and references #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions charts/mcp-stack/templates/deployment-mcpgateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,32 +88,10 @@ spec:
################################################################
# HEALTH & READINESS PROBES
################################################################
{{- if .Values.migration.enabled }}
startupProbe:
exec:
command:
- /bin/sh
- -c
- |
# Check if migration check already passed
if [ -f /tmp/migration_check_done ]; then
exit 0
fi
# Wait for database to be ready (implies migration completed)
python3 /app/mcpgateway/utils/db_isready.py --max-tries 1 --interval 1 --timeout 2 || exit 1
# Mark check as done to avoid repeated database calls
touch /tmp/migration_check_done
exit 0
initialDelaySeconds: 10
periodSeconds: 5
timeoutSeconds: 10
failureThreshold: 60 # Allow up to 5 minutes for migration to complete
{{- else }}
{{- with .Values.mcpContextForge.probes.startup }}
startupProbe:
{{- include "helpers.renderProbe" (dict "probe" . "root" $) | nindent 12 }}
{{- end }}
{{- end }}

{{- with .Values.mcpContextForge.probes.readiness }}
readinessProbe:
Expand Down
76 changes: 0 additions & 76 deletions charts/mcp-stack/templates/job-migration.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions charts/mcp-stack/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,12 +628,12 @@
},
"migration": {
"type": "object",
"description": "Database migration configuration",
"description": "DEPRECATED: no-op (migrations are automated now). Kept for backward compatibility.",
"properties": {
"enabled": {
"type": "boolean",
"description": "Enable database migrations",
"default": true
"default": false
},
"restartPolicy": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion charts/mcp-stack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ mcpContextForge:
# Runs as a Job before mcpgateway deployment
########################################################################
migration:
enabled: true # Set to false to skip migrations
enabled: false # DEPRECATED: ignored; migrations are automated now.

# Job configuration
restartPolicy: Never # Job should not restart on failure
Expand Down