[WIP] GradedArraysNext #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Nov 18, 2025
Comment on lines
+24
to
+27
| const GradedUnitRange{I, R1, R2} = | ||
| BlockUnitRange{Int, Vector{SectorUnitRange{I, R1, R2}}, Vector{Int}, BlockedOneTo{Int, Vector{Int}}} | ||
|
|
||
| function Base.similar( | ||
| a::AbstractArray, elt::Type, axes::Tuple{SectorOneTo, Vararg{SectorOneTo}} | ||
| ) | ||
| return similar(a, elt, Base.OneTo.(length.(axes))) | ||
| end | ||
| const GradedOneTo{I} = GradedUnitRange{I, Base.OneTo{Int}, Base.OneTo{Int}} |
Member
There was a problem hiding this comment.
I think this should be something like this:
Suggested change
| const GradedUnitRange{I, R1, R2} = | |
| BlockUnitRange{Int, Vector{SectorUnitRange{I, R1, R2}}, Vector{Int}, BlockedOneTo{Int, Vector{Int}}} | |
| function Base.similar( | |
| a::AbstractArray, elt::Type, axes::Tuple{SectorOneTo, Vararg{SectorOneTo}} | |
| ) | |
| return similar(a, elt, Base.OneTo.(length.(axes))) | |
| end | |
| const GradedOneTo{I} = GradedUnitRange{I, Base.OneTo{Int}, Base.OneTo{Int}} | |
| const GradedUnitRange{I, R1, R2} = | |
| BlockUnitRange{Int, Vector{SectorUnitRange{I, R1, R2}}, Vector{Int}} | |
| const GradedOneTo{I, R1, R2} = BlockOneTo{Int, Vector{SectorUnitRange{I, R1, R2}}, Vector{Int}} |
using BlockOneTo.
mtfishman
reviewed
Nov 19, 2025
| # @testset "svd_compact (eltype=$elt)" for elt in elts | ||
| elt = Float64 | ||
| for i in [2, 3], j in [2, 3], k in [2, 3], l in [2, 3] | ||
| r1 = gradedrange([U1(0) => i, U1(1) => j]) |
Member
There was a problem hiding this comment.
We could add back gradedrange as a constructor (which would call blockrange internally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large WIP of my progress for the GradedArraysNext refactor.
The main problem to simply start merging is that the testsuite needs either updating or marking things as broken, and I don't think I can find the time to get that done before tomorrow, so for now I'll just leave this as is.