Use direct podman commands for image deployment #189
+139
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obyknovenius
approved these changes
Nov 17, 2025
| run: | | ||
| source ./register-sdk-on-host.sh | ||
| wkdev-sdk-bakery --mode=build --verbose --arch amd64 | ||
| podman build -t ${REPO}:${WKDEV_SDK_TAG}_amd64 --arch=amd64 images/wkdev_sdk |
Collaborator
There was a problem hiding this comment.
Just a heads up, one thing we're missing compared to wkdev-sdk-bakery is the --jobs argument. Presumably doesn't make a big difference for the image build anyway.
aoikonomopoulos
approved these changes
Nov 17, 2025
Collaborator
aoikonomopoulos
left a comment
aoikonomopoulos
left a comment
There was a problem hiding this comment.
LGTM, with the usual caveat about the duplication between amd64/arm64.
nikolaszimmermann
force-pushed
the
nzimmermann/optimize_build_time
branch
from
4136129 to
b8e738e
Compare
Replace wkdev-sdk-bakery script with direct podman commands for building and deploying container images, matching the pattern from webkit-container-sdk-bots. Main changes: - Build jobs now use direct podman build/push instead of bakery script - Remove artifact upload/download steps for faster workflow execution - Push arch-specific images directly to registry after build - Deploy job validates images exist before creating manifest - Add rollback cleanup if validation fails - Clean up intermediate arch-specific tags after successful deployment - Fix WKDEV_SDK_TAG to use GITHUB_REF_NAME instead of GITHUB_BASE_REF - Add debug output for troubleshooting tag variables Should lead to much faster builds + deployments.
nikolaszimmermann
force-pushed
the
nzimmermann/optimize_build_time
branch
from
b8e738e to
81a4318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace wkdev-sdk-bakery script with direct podman commands for building and deploying container images, matching the pattern from webkit-container-sdk-bots.
Main changes:
Should lead to much faster builds + deployments.