-
Notifications
You must be signed in to change notification settings - Fork 159
Grid Cell merging #16024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Grid Cell merging #16024
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@dkamburov , @MayaKirova , I concluded testing the scenarios that I intended . Putting this as verified as I prefer the bulk to be merged and the items I found be handled as separate prs but you can go on about it as you wish. I'll be on PTO until Tuesday so you can have someone else verify fixes if they become available prior. |
@ChronosSF @dkamburov Sure, I can add fixes in separate PRs. Just a side note about the one with master-detail: This is expected, because activation and/or selection is on the collapsed cell. And as per the spec activation/selection break the merge sequence. All additional fixes can be found here and can be tested/merged separately: #16107 |
Fix cell merge styling issues.
projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss
Outdated
Show resolved
Hide resolved
|
||
%igx-grid__td--merged-selected { | ||
color: var-get($theme, 'row-selected-text-color'); | ||
background: var-get($theme, 'row-selected-background') !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is important needed here and in the consequent placeholder selectors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because if the pinned cell style:
%grid-cell--pinned {
position: relative;
background: inherit;
z-index: 9999;
}
It overwrites the background, when the cell is also pinned.
Co-authored-by: Simeon Simeonoff <[email protected]>
…I/igniteui-angular into mkirova/cell-merge-POC-2
Grid cell merging feature as per spec
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)