-
Notifications
You must be signed in to change notification settings - Fork 160
Handle validation for fields with '.' - 19.2.x #16053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.2.x
Are you sure you want to change the base?
Conversation
* @internal | ||
*/ | ||
public getTransformedFieldName(field: string): string { | ||
return field?.replace(/\./g, '_'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's an edge case, but I'm not sure about it. If we have column test.1 and test_1, we'll mess up the validation, I guess we are good with this, but should be at least very well described in the docs.
Or even better we should use a bit more complex identifier to replace with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getFieldKey can be deleted because it is not used anymore. |
Closes #15932
Changes:
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)