fix: yaml secret file parsing #3837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added robust YAML parsing support for secret file imports with proper handling of multiline strings and content types.
- New content-type detection in
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretDropzone/SecretDropzone.tsxnow properly identifies YAML files with content types 'text/yaml', 'application/x-yaml', and 'application/yaml' - Added dedicated
parseYamlfunction infrontend/src/components/utilities/parseSecrets.tsthat correctly processes multiline string formats using YAML block scalar styles (|, |-, >) - Security: Ensure input validation and sanitization are robust when parsing user-provided YAML files to prevent potential injection attacks or malformed data
- Documentation: No docs update in
/docsfolder for this new YAML import feature - customers need to know supported YAML formats and limitations
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Fix YAML content type handling in secrets import - #3832
Type ✨
Tests 🛠️