Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Sep 23, 2025

Closes #

Proposed Changes

  • Related to this PR.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Sep 23, 2025
@NguyenHoangSon96 NguyenHoangSon96 added this to the 2.11.0 milestone Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.06%. Comparing base (66cec9e) to head (1000900).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #195       +/-   ##
===========================================
- Coverage   93.04%   82.06%   -10.98%     
===========================================
  Files          16       18        +2     
  Lines        1596     1974      +378     
===========================================
+ Hits         1485     1620      +135     
- Misses         83      314      +231     
- Partials       28       40       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for the difference in test coverage is the change to line 107 and to line 109 in .circleci/config.yml which is now also testing examples and adding them to the report. These were not tested in the past.

Compare...

PR 193
https://output.circle-artifacts.com/output/job/ef0c007e-3273-4576-95e9-40b3dfc9b815/artifacts/0/tmp/artifacts/coverage.html#file0

Last PR Merge
https://output.circle-artifacts.com/output/job/94df9344-1672-468c-a525-b93b8e7ac874/artifacts/0/tmp/artifacts/coverage.html#file0

PR 195 (this PR)
https://output.circle-artifacts.com/output/job/6b174d2b-d7e3-40cc-ac1a-fb0320d5ba7a/artifacts/0/tmp/artifacts/coverage.html#file0

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last review comment

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that batching tests are missing from the coverage report. My suggestion yesterday was inexact.

command: |
if [[ "$CIRCLE_BRANCH" == pull/* ]]; then
GOEXPERIMENT=nocoverageredesign go test -v -cover -coverprofile=coverage.out ./...
go test -coverprofile=coverage.out ./influxdb3/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my suggestion yesterday was inexact. I notice now that tests in influxdb3/batching are not being run. I think the correct command is most likely.

go test -v -cover -coverprofile=coverage.out ./influxdb3/...

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason coverage is still down 11%. Haven't time right now to experiment further.

@NguyenHoangSon96
Copy link
Contributor Author

For some reason coverage is still down 11%. Haven't time right now to experiment further.

The cause for this may be that it includes testutil/mocks in the reports. Still working on finding the fix.
Screenshot 2025-09-25 at 16 05 00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants