Skip to content

feat: Replace UserAvatar module with Avatar and remove it altogether #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025

Conversation

LunarX
Copy link
Collaborator

@LunarX LunarX commented Jul 30, 2025

This is the last usage of the old UserAvatar module. This PR replaces its usage with the new more generic Avatar and removes the whole UserAvatar module.

This also required me the fix the way we instantiate image loaders inside of ksuite and crossapp login to make sure we use unauthenticated ones when loading user avatars

Closes #460

LunarX added 4 commits July 30, 2025 09:46
Delete the UserAvatar module permanently after replacing its last usage with the new Avatar module
It's needed when using for newImageLoader() because it references TokenInterceptorListener
@LunarX LunarX requested a review from LouisCAD July 30, 2025 08:42
@LunarX LunarX self-assigned this Jul 30, 2025
@LunarX LunarX added the feature A new functionality is added to the product label Jul 30, 2025
Copy link

sonarqubecloud bot commented Jul 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LouisCAD LouisCAD merged commit b0a8a06 into main Jul 30, 2025
7 checks passed
@LouisCAD LouisCAD deleted the replace-useravatar-with-avatar branch July 30, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality is added to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants