feat: Update onboarding to compose #2733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
update-onboarding-to-compose
branch
from
cf477dd to
eae4d25
Compare
LunarX
force-pushed
the
factorize-login-logic
branch
2 times, most recently
from
9204fcc to
b8ce10d
Compare
tevincent
requested changes
Dec 2, 2025
app/src/main/java/com/infomaniak/mail/ui/login/components/AccentColorSelector.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/login/components/AccentColorSelector.kt
Outdated
Show resolved
Hide resolved
Contributor
|
And 2 new issues from Sonar. |
LunarX
force-pushed
the
update-onboarding-to-compose
branch
from
eae4d25 to
0880cca
Compare
LunarX
force-pushed
the
update-onboarding-to-compose
branch
from
0880cca to
6ecb734
Compare
|
This PR/issue depends on: |
tevincent
requested changes
Dec 3, 2025
Contributor
tevincent
left a comment
tevincent
left a comment
There was a problem hiding this comment.
It seems when you don't have any mailboxes, if you go back to the onboarding, buttons are in a loading state and stay like that 4ever.
…ut failed to get mailboxes
|
tevincent
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the compose onboarding module on mail like in other apps. This lead to a bunch of code being deleted because not used anymore.
Depends on #2728
Depends on Infomaniak/android-core#617