Skip to content

Conversation

@rmarting
Copy link
Contributor

@rmarting rmarting commented Mar 3, 2025

This PR is a small contribution to align some references between Host and Core team in the introduction learning path. This is part of the conversation of the issue #594 and it could help to resolve misunderstandings for the new readers.

A reference of the Core Team pattern is added in some places to facilitate the connection with it, and give a better context of this team in the InnerSource contribution workflow.

The PR includes also the traslation into the current languages the changes added here.

@rmarting rmarting requested a review from a team as a code owner March 3, 2025 06:45
@rrrutledge
Copy link
Contributor

Thanks for this work! How did you do the translations?

@rmarting
Copy link
Contributor Author

rmarting commented Apr 3, 2025

@rrrutledge As the changes are simple ones, I used different AI tools to get the translations. Those are also open to get a review or feedback for native speakers, if it is needed.

@rrrutledge
Copy link
Contributor

I’m sorry I haven’t gotten to this. Still on my radar.

@rrrutledge
Copy link
Contributor

Sorry it took so long to get to this. Our way of working has been to get a native speaker to review each machine-generated translation. This change is small, so it may not be needed, but let's try.

@rrrutledge
Copy link
Contributor

rrrutledge commented Apr 22, 2025

I'll nominate the following people to review the given language translation. It will take you ~1min, so just do it now and leave your review? Thank you!

@MaineC
Copy link
Member

MaineC commented Apr 22, 2025

The translation sounds reasonable.

Only caveat: it translates the term host team. If we do that in all German learning path segments and patterns that is fine, otherwise it may cause minor confusions.

Copy link
Member

@tfroment tfroment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested one change as it was not fully translated in FR

@MaineC
Copy link
Member

MaineC commented Apr 22, 2025

@rrrutledge thanks for the time estimate, that helped make the decision to squeeze the proof reading in just now

Copy link
Member

@tfroment tfroment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you @rmarting

@rmarting
Copy link
Contributor Author

Thank @afucher for your review and proposals! Changes accepted!

Copy link
Contributor

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the Chinese translation comments.

=== 额外的资源
* https://patterns.innersourcecommons.org/p/trusted-committer[Trusted Committer] 的模式。

* 主办团队通常以 https://patterns.innersourcecommons.org/p/core-team[核心团队] 模式表示。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use “主导团队” instead of “主办团队“ here, and we don't translate Trusted Committer , as it's hard to find a right Chinese term for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WillemJiang Could you double check that I committed the right changes?


在可能的情况下,从团队对项目的内部定义到特定于项目的特殊情况场景,都应该清晰而详细地传达上述内容。
这种沟通应该以一种容易被非核心团队成员查询和理解的方式进行
此沟通应以一种易于查询和理解的方式进行,以便那些不属于主办团队的人员能够理解
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use “主导团队” instead of “主办团队“ here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WillemJiang Could you double check that I committed the right changes?

Copy link
Contributor

@mzleo mzleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work!
Please check my comments about the Japanese translation.

@rmarting
Copy link
Contributor Author

Thanks for this work! Please check my comments about the Japanese translation.

Thanks @mzleo for your review! Your changes were merged!

Copy link
Contributor

@mzleo mzleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!, Thank you @rmarting :shipit:

svc-mesto

This comment was marked as duplicate.

@voborgus
Copy link
Collaborator

OK for Russian translation, thanks!

Sorry, GH accidentally choose service account for commenting, this was me :)
RU translation is correct.

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like feedback received from all languages 🏳️ 💥 ❗

@rmarting
Copy link
Contributor Author

Then, are we ready to merge it and close this PR? Askig for a friend! 😉

@rrrutledge
Copy link
Contributor

Yup - If you think all feedback has been incorporated then let’s do it!

@rrrutledge rrrutledge merged commit 92de755 into InnerSourceCommons:main May 26, 2025
1 check passed
@rrrutledge
Copy link
Contributor

OK - done. The automation should take it to the website, but have a double-check to see 👀

@rmarting rmarting deleted the issue-594-core-team branch June 2, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants