-
Notifications
You must be signed in to change notification settings - Fork 47
Minor fix to align Host and Core team references #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix to align Host and Core team references #599
Conversation
|
Thanks for this work! How did you do the translations? |
|
@rrrutledge As the changes are simple ones, I used different AI tools to get the translations. Those are also open to get a review or feedback for native speakers, if it is needed. |
|
I’m sorry I haven’t gotten to this. Still on my radar. |
|
Sorry it took so long to get to this. Our way of working has been to get a native speaker to review each machine-generated translation. This change is small, so it may not be needed, but let's try. |
|
I'll nominate the following people to review the given language translation. It will take you ~1min, so just do it now and leave your review? Thank you!
|
|
The translation sounds reasonable. Only caveat: it translates the term host team. If we do that in all German learning path segments and patterns that is fine, otherwise it may cause minor confusions. |
tfroment
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested one change as it was not fully translated in FR
|
@rrrutledge thanks for the time estimate, that helped make the decision to squeeze the proof reading in just now |
Co-authored-by: rrrutledge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thank you @rmarting
Co-authored-by: Arthur Fücher <[email protected]>
Co-authored-by: Arthur Fücher <[email protected]>
Co-authored-by: Arthur Fücher <[email protected]>
|
Thank @afucher for your review and proposals! Changes accepted! |
WillemJiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the Chinese translation comments.
| === 额外的资源 | ||
| * https://patterns.innersourcecommons.org/p/trusted-committer[Trusted Committer] 的模式。 | ||
|
|
||
| * 主办团队通常以 https://patterns.innersourcecommons.org/p/core-team[核心团队] 模式表示。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use “主导团队” instead of “主办团队“ here, and we don't translate Trusted Committer , as it's hard to find a right Chinese term for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WillemJiang Could you double check that I committed the right changes?
|
|
||
| 在可能的情况下,从团队对项目的内部定义到特定于项目的特殊情况场景,都应该清晰而详细地传达上述内容。 | ||
| 这种沟通应该以一种容易被非核心团队成员查询和理解的方式进行。 | ||
| 此沟通应以一种易于查询和理解的方式进行,以便那些不属于主办团队的人员能够理解。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use “主导团队” instead of “主办团队“ here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WillemJiang Could you double check that I committed the right changes?
mzleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work!
Please check my comments about the Japanese translation.
Co-authored-by: Leona Matsumoto <[email protected]>
Co-authored-by: Leona Matsumoto <[email protected]>
Thanks @mzleo for your review! Your changes were merged! |
mzleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!, Thank you @rmarting ![]()
Sorry, GH accidentally choose service account for commenting, this was me :) |
rrrutledge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like feedback received from all languages 🏳️ 💥 ❗
|
Then, are we ready to merge it and close this PR? Askig for a friend! 😉 |
|
Yup - If you think all feedback has been incorporated then let’s do it! |
|
OK - done. The automation should take it to the website, but have a double-check to see 👀 |
This PR is a small contribution to align some references between Host and Core team in the introduction learning path. This is part of the conversation of the issue #594 and it could help to resolve misunderstandings for the new readers.
A reference of the Core Team pattern is added in some places to facilitate the connection with it, and give a better context of this team in the InnerSource contribution workflow.
The PR includes also the traslation into the current languages the changes added here.