Skip to content

STYLE: Remove unnecessary iterator GoToBegin() calls from Core #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

STYLE: Remove unnecessary iterator GoToBegin() calls from Core #4830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Modules/Core/Common/include/itkUnaryFunctorImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ UnaryFunctorImageFilter<TInputImage, TOutputImage, TFunction>::DynamicThreadedGe
ImageScanlineConstIterator inputIt(inputPtr, inputRegionForThread);
ImageScanlineIterator outputIt(outputPtr, outputRegionForThread);

inputIt.GoToBegin();
outputIt.GoToBegin();
while (!inputIt.IsAtEnd())
{
while (!inputIt.IsAtEndOfLine())
Expand Down
4 changes: 0 additions & 4 deletions Modules/Core/FiniteDifference/include/itkDenseFiniteDifferenceImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,6 @@ DenseFiniteDifferenceImageFilter<TInputImage, TOutputImage>::ThreadedApplyUpdate
ImageRegionIterator<UpdateBufferType> u(m_UpdateBuffer, regionToProcess);
ImageRegionIterator<OutputImageType> o(this->GetOutput(), regionToProcess);

u.GoToBegin();
o.GoToBegin();

while (!u.IsAtEnd())
{
o.Value() += static_cast<PixelType>(u.Value() * dt); // no adaptor
Expand Down Expand Up @@ -259,7 +256,6 @@ DenseFiniteDifferenceImageFilter<TInputImage, TOutputImage>::ThreadedCalculateCh
UpdateIteratorType bU(m_UpdateBuffer, *fIt);

bD.GoToBegin();
bU.GoToBegin();
while (!bD.IsAtEnd())
{
bU.Value() = df->ComputeUpdate(bD, globalData);
Expand Down
5 changes: 0 additions & 5 deletions Modules/Core/Mesh/include/itkBinaryMask3DMeshSource.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,11 +1037,6 @@ BinaryMask3DMeshSource<TInputImage, TOutputMesh>::CreateMesh()
InputImageIterator it3(m_InputImage, m_RegionOfInterest);
InputImageIterator it4(m_InputImage, m_RegionOfInterest);

it1.GoToBegin();
it2.GoToBegin();
it3.GoToBegin();
it4.GoToBegin();

InputImageSizeType inputImageSize = m_RegionOfInterest.GetSize();
m_ImageWidth = inputImageSize[0];
m_ImageHeight = inputImageSize[1];
Expand Down
2 changes: 0 additions & 2 deletions Modules/Core/Mesh/include/itkImageToParametricSpaceFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ ImageToParametricSpaceFilter<TInputImage, TOutputMesh>::GenerateData()

PointsContainerIterator point = points->Begin();

itr.GoToBegin();
while (!itr.IsAtEnd())
{
(point.Value())[component] = itr.Get();
Expand All @@ -123,7 +122,6 @@ ImageToParametricSpaceFilter<TInputImage, TOutputMesh>::GenerateData()
PointDataContainerIterator data = pointData->Begin();
image = this->GetInput(0);
ImageRegionConstIteratorWithIndex<InputImageType> itr(image, image->GetRequestedRegion());
itr.GoToBegin();
while (!itr.IsAtEnd())
{
// The data at each point is the index
Expand Down
16 changes: 7 additions & 9 deletions Modules/Core/SpatialObjects/include/itkSpatialObjectToImageStatisticsCalculator.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,10 @@ SpatialObjectToImageStatisticsCalculator<TInputImage, TInputSpatialObject, TSamp

using MaskIteratorType = ImageRegionConstIteratorWithIndex<MaskImageType>;
MaskIteratorType it(maskImage, maskImage->GetLargestPossibleRegion());
it.GoToBegin();
IndexType ind;
PointType pnt;
PointType tPnt;
VectorType mv;
IndexType ind;
PointType pnt;
PointType tPnt;
VectorType mv;
while (!it.IsAtEnd())
{
if (it.Get() > 0) // if inside the mask
Expand Down Expand Up @@ -186,10 +185,9 @@ SpatialObjectToImageStatisticsCalculator<TInputImage, TInputSpatialObject, TSamp

using IteratorType = ImageRegionConstIteratorWithIndex<ImageType>;
IteratorType it(m_Image, region);
it.GoToBegin();
IndexType ind;
PointType pnt;
VectorType mv;
IndexType ind;
PointType pnt;
VectorType mv;
while (!it.IsAtEnd())
{
ind = it.GetIndex();
Expand Down
3 changes: 0 additions & 3 deletions Modules/Core/TestKernel/include/itkTestingStretchIntensityImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ StretchIntensityImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateD
ImageRegionConstIterator<TInputImage> inputIt(inputPtr, inputRegionForThread);
ImageRegionIterator<TOutputImage> outputIt(outputPtr, outputRegionForThread);

inputIt.GoToBegin();
outputIt.GoToBegin();

while (!inputIt.IsAtEnd())
{
const InputPixelType x = inputIt.Get();
Expand Down