Skip to content

STYLE: Replace char with signed char as itk::Image argument in tests #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

STYLE: Replace char with signed char as itk::Image argument in tests #5465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkBSplineInterpolationWeightFunctionTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ itkBSplineInterpolationWeightFunctionTest(int, char *[])
using KernelType = itk::BSplineKernelFunction<SplineOrder>;
auto kernel = KernelType::New();

using ImageType = itk::Image<char, SpaceDimension>;
using ImageType = itk::Image<signed char, SpaceDimension>;
auto image = ImageType::New();
const ImageType::RegionType region{ startIndex, size };

Expand Down
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkConstNeighborhoodIteratorWithOnlyIndexTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ int
itkConstNeighborhoodIteratorWithOnlyIndexTest(int, char *[])
{
std::cout << "*** Testing with itk::Image" << std::endl << std::endl;
if (itkConstNeighborhoodIteratorWithOnlyIndexTestRun<itk::Image<char, 4>>() == EXIT_FAILURE)
if (itkConstNeighborhoodIteratorWithOnlyIndexTestRun<itk::Image<signed char, 4>>() == EXIT_FAILURE)
{
std::cerr << "XXX Failed with itk::Image XXX" << std::endl;
return EXIT_FAILURE;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/test/itkImageAlgorithmCopyTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ AverageTestCopy(typename TImage::SizeType & size)
int
itkImageAlgorithmCopyTest(int, char *[])
{
using ImageType3D = itk::Image<char, 3>;
using ImageType3D = itk::Image<signed char, 3>;
auto size3d = ImageType3D::SizeType::Filled(16);
AverageTestCopy<ImageType3D>(size3d);

Expand All @@ -131,7 +131,7 @@ itkImageAlgorithmCopyTest(int, char *[])
size3d.Fill(128);
AverageTestCopy<ImageType3D>(size3d);

using ImageType2D = itk::Image<char, 2>;
using ImageType2D = itk::Image<signed char, 2>;
auto size2d = ImageType2D::SizeType::Filled(16);
AverageTestCopy<ImageType2D>(size2d);

Expand Down
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkImageRegionConstIteratorWithOnlyIndexTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ itkImageRegionConstIteratorWithOnlyIndexTest(int, char *[])

{
std::cout << "Testing with Image< char, 3 >... " << std::endl;
itkImageRegionConstIteratorWithOnlyIndexTestIteratorTester<itk::Image<char, 3>> Tester;
itkImageRegionConstIteratorWithOnlyIndexTestIteratorTester<itk::Image<signed char, 3>> Tester;
if (Tester.TestConstIterator() == false)
{
testPassed = false;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkImageVectorOptimizerParametersHelperTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ itkImageVectorOptimizerParametersHelperTest(int, char *[])
ITK_TRY_EXPECT_EXCEPTION(params.MoveDataPointer(array.data_block()));

// Test setting an image of wrong type
using BadImageType = itk::Image<char, 2>;
using BadImageType = itk::Image<signed char, 2>;
auto badImage = BadImageType::New();
ITK_TRY_EXPECT_EXCEPTION(params.SetParametersObject(badImage));

Expand Down
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkMultiThreaderParallelizeArrayTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ itkMultiThreaderParallelizeArrayTest(int argc, char * argv[])
constexpr unsigned int size = 1029;
std::vector<unsigned int> vec(size);

using SomeProcessObject = itk::AbsImageFilter<itk::Image<char>, itk::Image<char>>;
using SomeProcessObject = itk::AbsImageFilter<itk::Image<signed char>, itk::Image<signed char>>;
auto progressPO = SomeProcessObject::New();
auto showProgress = ShowProgress::New();
progressPO->AddObserver(itk::ProgressEvent(), showProgress);
Expand Down
2 changes: 1 addition & 1 deletion Modules/Core/Common/test/itkSimpleFilterWatcherTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ itkSimpleFilterWatcherTest(int, char *[])
{
// Test out the code
using WatcherType = itk::SimpleFilterWatcher;
using ImageType = itk::Image<char, 3>;
using ImageType = itk::Image<signed char, 3>;
using FilterType = itk::TanHelperImageFilter<ImageType, ImageType>;
auto filter = FilterType::New();
const char * comment = "comment";
Expand Down
7 changes: 3 additions & 4 deletions Modules/Filtering/AntiAlias/test/itkAntiAliasBinaryImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ sphere(float x, float y, float z)
}

void
evaluate_function(itk::Image<char, 3> * im, float (*f)(float, float, float))
evaluate_function(itk::Image<signed char, 3> * im, float (*f)(float, float, float))
{
itk::Image<char, 3>::IndexType idx;
itk::Image<signed char, 3>::IndexType idx;

for (int z = 0; z < V_DEPTH; ++z)
{
Expand Down Expand Up @@ -88,8 +88,7 @@ itkAntiAliasBinaryImageFilterTest(int argc, char * argv[])
}
const char * outputImage = argv[1];

using InputDataType = char;
using BinaryImageType = itk::Image<InputDataType, 3>;
using BinaryImageType = itk::Image<signed char, 3>;
using RealImageType = itk::Image<float, 3>;

const itk::AntiAliasBinaryImageFilter<BinaryImageType, RealImageType>::Pointer antialiaser =
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ itkJoinImageFilterTest(int, char *[])
constexpr unsigned int myDimension = 2;

// Declare the types of the images
using myImageType1 = itk::Image<char, myDimension>;
using myImageType1 = itk::Image<signed char, myDimension>;
using myImageType2 = itk::Image<itk::Vector<unsigned short, 2>, myDimension>;
using myImageType3 = itk::Image<itk::RGBAPixel<short>, myDimension>;

Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/ImageFrequency/test/itkFrequencyIteratorsGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ template <typename TOutputImageType>
static typename TOutputImageType::Pointer
CreateImage(unsigned int size)
{
using ImageType = itk::Image<char, TOutputImageType::ImageDimension>;
using ImageType = itk::Image<signed char, TOutputImageType::ImageDimension>;
auto imageSize = ImageType::SizeType::Filled(size);
using RandomImageSourceType = itk::RandomImageSource<ImageType>;
auto randomImageSource = RandomImageSourceType::New();
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/ImageIntensity/test/itkShiftScaleImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ itkShiftScaleImageFilterTest(int, char *[])
{
std::cout << "itkShiftScaleImageFilterTest Start" << std::endl;

using TestInputImage = itk::Image<char, 3>;
using TestInputImage = itk::Image<signed char, 3>;
using TestOutputImage = itk::Image<unsigned char, 3>;
using RealType = itk::NumericTraits<char>::RealType;

Expand Down
2 changes: 1 addition & 1 deletion Modules/IO/ImageBase/test/itkImageFileReaderDimensionsTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ itkImageFileReaderDimensionsTest(int argc, char * argv[])
using Image2DType = itk::Image<short, 2>;
using Image3DType = itk::Image<short, 3>;
using Image4DType = itk::Image<short, 4>;
using CharImage2DType = itk::Image<char, 2>;
using CharImage2DType = itk::Image<signed char, 2>;

using Reader2DType = itk::ImageFileReader<Image2DType>;
using Reader3DType = itk::ImageFileReader<Image3DType>;
Expand Down
2 changes: 1 addition & 1 deletion Modules/IO/NIFTI/test/itkNiftiImageIOTest11.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ itkNiftiImageIOTest11(int argc, char * argv[])
{
return EXIT_FAILURE;
}
using ImageType = itk::Image<char, 3>;
using ImageType = itk::Image<signed char, 3>;

ImageType::SizeType size;
size[0] = static_cast<long>(itk::NumericTraits<short>::max()) * 2;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Registration/Common/test/itkImageRegistrationMethodTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ itkImageRegistrationMethodTest(int, char *[])
using FixedImageType = itk::Image<float, dimension>;

// Moving Image Type
using MovingImageType = itk::Image<char, dimension>;
using MovingImageType = itk::Image<signed char, dimension>;

// Transform Type
using TransformType = itk::TranslationTransform<double, dimension>;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Registration/Common/test/itkImageRegistrationMethodTest_11.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ itkImageRegistrationMethodTest_11(int, char *[])
using FixedImageType = itk::Image<float, dimension>;

// Moving Image Type
using MovingImageType = itk::Image<char, dimension>;
using MovingImageType = itk::Image<signed char, dimension>;

// Transform Type
using TransformType = itk::TranslationTransform<double, dimension>;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Registration/Common/test/itkMultiResolutionImageRegistrationMethodTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ itkMultiResolutionImageRegistrationMethodTest(int, char *[])
using FixedImageType = itk::Image<float, dimension>;

// Moving Image Type
// using MovingImageType = itk::Image<char,dimension>;
// using MovingImageType = itk::Image<signed char,dimension>;
using MovingImageType = itk::Image<float, dimension>;

// Transform Type
Expand Down
6 changes: 3 additions & 3 deletions Modules/Segmentation/LevelSets/test/itkCannySegmentationLevelSetImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace CSIFTN
{

using ImageType = itk::Image<float, 3>;
using SeedImageType = itk::Image<char, 3>;
using SeedImageType = itk::Image<signed char, 3>;

constexpr int V_WIDTH = 64;
constexpr int V_HEIGHT = 64;
Expand Down Expand Up @@ -79,9 +79,9 @@ evaluate_float_function(itk::Image<float, 3> * im, float (*f)(float, float, floa
}

void
evaluate_function(itk::Image<char, 3> * im, float (*f)(float, float, float))
evaluate_function(itk::Image<signed char, 3> * im, float (*f)(float, float, float))
{
itk::Image<char, 3>::IndexType idx;
itk::Image<signed char, 3>::IndexType idx;

for (int z = 0; z < V_DEPTH; ++z)
{
Expand Down
6 changes: 3 additions & 3 deletions Modules/Segmentation/LevelSets/test/itkLaplacianSegmentationLevelSetImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace LSIFTN
{

using ImageType = itk::Image<float, 3>;
using SeedImageType = itk::Image<char, 3>;
using SeedImageType = itk::Image<signed char, 3>;

constexpr int V_WIDTH = 64;
constexpr int V_HEIGHT = 64;
Expand Down Expand Up @@ -80,9 +80,9 @@ evaluate_float_function(itk::Image<float, 3> * im, float (*f)(float, float, floa
}

void
evaluate_function(itk::Image<char, 3> * im, float (*f)(float, float, float))
evaluate_function(itk::Image<signed char, 3> * im, float (*f)(float, float, float))
{
itk::Image<char, 3>::IndexType idx;
itk::Image<signed char, 3>::IndexType idx;

for (int z = 0; z < V_DEPTH; ++z)
{
Expand Down
6 changes: 3 additions & 3 deletions ...Segmentation/LevelSets/test/itkNarrowBandThresholdSegmentationLevelSetImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace NBTS
{

using ImageType = itk::Image<float, 3>;
using SeedImageType = itk::Image<char, 3>;
using SeedImageType = itk::Image<signed char, 3>;

constexpr int V_WIDTH = 64;
constexpr int V_HEIGHT = 64;
Expand All @@ -40,9 +40,9 @@ sphere(float x, float y, float z)
}

void
evaluate_function(itk::Image<char, 3> * im, float (*f)(float, float, float))
evaluate_function(itk::Image<signed char, 3> * im, float (*f)(float, float, float))
{
itk::Image<char, 3>::IndexType idx;
itk::Image<signed char, 3>::IndexType idx;

for (int z = 0; z < V_DEPTH; ++z)
{
Expand Down
6 changes: 3 additions & 3 deletions Modules/Segmentation/LevelSets/test/itkThresholdSegmentationLevelSetImageFilterTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace TSIFTN
{

using ImageType = itk::Image<float, 3>;
using SeedImageType = itk::Image<char, 3>;
using SeedImageType = itk::Image<signed char, 3>;

constexpr int V_WIDTH = 64;
constexpr int V_HEIGHT = 64;
Expand All @@ -40,9 +40,9 @@ sphere(float x, float y, float z)
}

void
evaluate_function(itk::Image<char, 3> * im, float (*f)(float, float, float))
evaluate_function(itk::Image<signed char, 3> * im, float (*f)(float, float, float))
{
itk::Image<char, 3>::IndexType idx;
itk::Image<signed char, 3>::IndexType idx;

for (int z = 0; z < V_DEPTH; ++z)
{
Expand Down
2 changes: 1 addition & 1 deletion Modules/Segmentation/LevelSetsv4/test/itkBinaryImageToShiSparseLevelSetAdaptorTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ itkBinaryImageToShiSparseLevelSetAdaptorTest(int argc, char * argv[])

const LevelSetType::Pointer sparseLevelSet = adaptor->GetModifiableLevelSet();

using StatusImageType = itk::Image<char, Dimension>;
using StatusImageType = itk::Image<signed char, Dimension>;
auto statusImage = StatusImageType::New();
statusImage->SetRegions(input->GetLargestPossibleRegion());
statusImage->CopyInformation(input);
Expand Down
Loading