Skip to content

Use CalculateProductOfElements in Denoising, ImageStatistics, and IO tests #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

Use CalculateProductOfElements in Denoising, ImageStatistics, and IO tests #5541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f85797
STYLE: Use CalculateProductOfElements in PatchBasedDenoisingBase filter
N-Dekker Sep 26, 2025
c1e2f78
STYLE: Use CalculateProductOfElements in ImageStatistics/PCA
N-Dekker Oct 2, 2025
66b4758
STYLE: Use CalculateProductOfElements in large image write/read tests
N-Dekker Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Modules/Filtering/Denoising/include/itkPatchBasedDenoisingBaseImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,7 @@ PatchBasedDenoisingBaseImageFilter<TInputImage, TOutputImage>::GetPatchLengthInV
{
const PatchRadiusType diameter = this->GetPatchDiameterInVoxels();

typename PatchRadiusType::SizeValueType length = 1;
for (unsigned int dim = 0; dim < ImageDimension; ++dim)
{
length *= diameter[dim];
}
return length;
return diameter.CalculateProductOfElements();
}

template <typename TInputImage, typename TOutputImage>
Expand Down
6 changes: 1 addition & 5 deletions Modules/Filtering/ImageStatistics/include/itkImagePCADecompositionCalculator.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,7 @@ void
ImagePCADecompositionCalculator<TInputImage, TBasisImage>::CalculateBasisMatrix()
{
m_Size = m_BasisImages[0]->GetRequestedRegion().GetSize();
m_NumPixels = 1;
for (unsigned int i = 0; i < BasisImageDimension; ++i)
{
m_NumPixels *= m_Size[i];
}
m_NumPixels = m_Size.CalculateProductOfElements();

m_BasisMatrix = BasisMatrixType(static_cast<unsigned int>(m_BasisImages.size()), m_NumPixels);

Expand Down
6 changes: 1 addition & 5 deletions Modules/Filtering/ImageStatistics/include/itkImagePCAShapeModelEstimator.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,7 @@ ImagePCAShapeModelEstimator<TInputImage, TOutputImage>::CalculateInnerProduct()
// training data
m_InputImageSize = (inputImagePointerArray[0])->GetBufferedRegion().GetSize();

m_NumberOfPixels = 1;
for (unsigned int i = 0; i < InputImageDimension; ++i)
{
m_NumberOfPixels *= m_InputImageSize[i];
}
m_NumberOfPixels = m_InputImageSize.CalculateProductOfElements();

// Calculate the means
m_Means.set_size(m_NumberOfPixels);
Expand Down
6 changes: 1 addition & 5 deletions Modules/IO/ImageBase/test/itkLargeImageWriteReadTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ ActualTest(std::string filename, typename TImageType::SizeType size)

image->SetRegions(region);

size_t numberOfPixels = 1;
for (unsigned int i = 0; i < ImageType::ImageDimension; ++i)
{
numberOfPixels *= region.GetSize(i);
}
const size_t numberOfPixels = size.CalculateProductOfElements();

const size_t sizeInMebiBytes = sizeof(PixelType) * numberOfPixels / (1024 * 1024);

Expand Down
6 changes: 1 addition & 5 deletions Modules/IO/Meta/test/itkLargeMetaImageWriteReadTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,7 @@ ActualTest(std::string filename, typename TImageType::SizeType size)

image->SetRegions(region);

size_t numberOfPixels = 1;
for (unsigned int i = 0; i < ImageType::ImageDimension; ++i)
{
numberOfPixels *= region.GetSize(i);
}
const size_t numberOfPixels = size.CalculateProductOfElements();

const size_t sizeInMebiBytes = sizeof(PixelType) * numberOfPixels / (1024 * 1024);

Expand Down
6 changes: 1 addition & 5 deletions Modules/IO/TIFF/test/itkLargeTIFFImageWriteReadTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@ itkLargeTIFFImageWriteReadTestHelper(std::string filename, typename TImage::Size

image->SetRegions(region);

SizeValueType numberOfPixels = 1;
for (unsigned int i = 0; i < ImageType::ImageDimension; ++i)
{
numberOfPixels *= static_cast<SizeValueType>(region.GetSize(i));
}
const SizeValueType numberOfPixels = size.CalculateProductOfElements();

constexpr SizeValueType oneMebiByte = static_cast<SizeValueType>(1024) * static_cast<SizeValueType>(1024);

Expand Down
Loading