Add dtype keyword argument to dpnp.fft.fftfreq and dpnp.fft.rfftfreq
#2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
antonwolfy
changed the title
dtype keyword argument to dpnp.fftfreq and dpnp.rfftfreqdtype keyword argument to dpnp.fft.fftfreq and dpnp.fft.rfftfreq
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_48 ran successfully. |
vtavana
approved these changes
Mar 25, 2025
github-actions bot
added a commit
that referenced
this pull request
Mar 25, 2025
…freq` (#2384) The PR proposes to align `dpnp.fft.fftfreq` and `dpnp.fft.rfftfreq` functions with [2024.12](https://data-apis.org/array-api/2024.12/extensions/generated/array_api.fft.fftfreq.html) revision of Python array API spec where `dtype` keyword was specified for the functions. Additionally, implementation of `dpnp.fft.fftfreq` was reworked a bit to consume less memory and to avoid allocating temporary arrays. Also docstrings of FFT functions were improved to add blank lines prior defaults values. 04bfac7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to align
dpnp.fft.fftfreqanddpnp.fft.rfftfreqfunctions with 2024.12 revision of Python array API spec wheredtypekeyword was specified for the functions.Additionally, implementation of
dpnp.fft.fftfreqwas reworked a bit to consume less memory and to avoid allocating temporary arrays.Also docstrings of FFT functions were improved to add blank lines prior defaults values.