Skip to content

Remove temporary workaround in tests where "in_order" SYCL queue was used #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove temporary workaround in tests where "in_order" SYCL queue was used #2528

wants to merge 2 commits into from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 16, 2025 •
edited
Loading

The PR removes temporary w/a implemented due to crash on Windows in test_random and test_random_state.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Jul 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_14 ran successfully.
Passed: 1226
Failed: 1
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 16, 2025 •
edited
Loading

Coverage Status

coverage: 72.092%. remained the same
when pulling 4e9c064 on remove-wa-sat-7414
into fed6925 on master.

@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2528/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov will be requested when the pull request is marked ready for review AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana will be requested when the pull request is marked ready for review vtavana is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian will be requested when the pull request is marked ready for review ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @coveralls