Implement dpnp.linalg.lu_solve() 2D inputs
#2575
Open
+455
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
AlexanderKalistratov,
vtavana and
ndgrigorian
as code owners
antonwolfy
changed the title
dpnp.linalg.solve() 2D inputs dpnp.linalg.lu_solve() 2D inputs
|
Array API standard conformance tests for dpnp=0.19.0dev4=py313h509198e_19 ran successfully. |
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2575/index.html |
antonwolfy
reviewed
Sep 5, 2025
| depends=dep_evs, | ||
| ) | ||
| _manager.add_event_pair(ht_ev, piv_copy_ev) | ||
| # MKL lapack uses 1-origin while SciPy uses 0-origin |
There was a problem hiding this comment.
I guess SciPy also uses MKL to call getrs, so it seems unclear for me.
vlad-perevezentsev
force-pushed
the
impl_lu_solve_2D
branch
from
6a3bae1 to
b1aed58
Compare
antonwolfy
reviewed
Sep 19, 2025
antonwolfy
reviewed
Sep 20, 2025
| See Also | ||
| -------- | ||
| :obj:`dpnp.linalg.lu_factor` : LU factorize a matrix. |
There was a problem hiding this comment.
Please add See also section to lu_factor docstring also
antonwolfy
reviewed
Sep 20, 2025
| assert_raises(ValueError, dpnp.linalg.lu_factor, a, check_finite=True) | ||
|
|
||
|
|
||
| class TestLuSolve: |
There was a problem hiding this comment.
Any plans to enable cupy tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding
dpnp.linalg.lu_solve()for 2D arrays similar to scipy.linalg.lu_solveSupport for ND inputs will be added in the next phase.