Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 15, 2025

The PR excludes the headers files under backend/kernels/elementwise_functions from the coverage report, because there is no way to cover structures used inside the SYCL kernels.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 15, 2025
@antonwolfy antonwolfy self-assigned this Oct 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_19 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Oct 15, 2025

Coverage Status

coverage: 74.446% (+6.6%) from 67.845%
when pulling 3febb00 on exclude-kernels-headers-from-default-coverage
into 37db1c5 on master.

@antonwolfy antonwolfy marked this pull request as ready for review October 15, 2025 16:46
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy
A small suggestion for the next PR:
Could you also exclude dpnp/to_numba folder from the coverage report?

@antonwolfy
Copy link
Contributor Author

Could you also exclude dpnp/to_numba folder from the coverage report?

I think the folder has to be removed at all. It can be done in the follow up PR.

@antonwolfy antonwolfy merged commit 1eb4594 into master Oct 22, 2025
73 of 81 checks passed
@antonwolfy antonwolfy deleted the exclude-kernels-headers-from-default-coverage branch October 22, 2025 10:31
github-actions bot added a commit that referenced this pull request Oct 22, 2025
The PR excludes the headers files under
`backend/kernels/elementwise_functions` from the coverage report,
because there is no way to cover structures used inside the SYCL
kernels. 1eb4594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants