Fix sidebar accessibility on Identity pages by handling null TOC_DATA #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar hamburger menu button was inaccessible on Identity pages (e.g.,
/Identity/Account/Login
,/Identity/Account/Register
) due to JavaScript errors that prevented the Vue.js application from initializing properly.Root Cause
On Identity pages, the
TOC_DATA
global variable and other ViewBag-dependent variables arenull
because these pages don't have table of contents data. The JavaScript code was attempting to iterate over these null values without proper null checks, causing runtime errors:Solution
Implemented defensive programming practices throughout the JavaScript code:
markRaw(TOC_DATA || [])
provides empty array fallbackfindCurrentPage()
functionfilteredTocData
tocData.forEach()
Result
The changes are minimal and surgical, focusing only on null safety without altering the core sidebar functionality or user experience.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.hcaptcha.com
/usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/EssentialCSharp.Web/EssentialCSharp.Web/EssentialCSharp.Web.Tests/bin/Debug/net9.0/EssentialCSharp.Web.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/EssentialCSharp.Web/EssentialCSharp.Web/EssentialCSharp.Web.Tests/bin/Debug/net9.0/EssentialCSharp.Web.Tests.deps.json /home/REDACTED/work/EssentialCSharp.Web/EssentialCSharp.Web/EssentialCSharp.Web.Tests/bin/Debug/net9.0/testhost.dll --port 34247 --endpoint 127.0.0.1:034247 --role client --parentprocessid 6139 --telemetryoptedin false
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.