Add Gloo communication to turobmind #3362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irexyc
changed the title
|
oc evaluate diff.csv |
lvhan028
reviewed
May 12, 2025
lvhan028
reviewed
May 12, 2025
lvhan028
reviewed
May 12, 2025
lzhangzz
reviewed
Jun 27, 2025
| cfg.devices = cfg.devices if cfg.devices else list(range(cfg.device_num)) | ||
| cfg.ngpus_per_node = cfg.ngpus_per_node or len(cfg.devices) | ||
| # for simplicity, each node has dp | ||
| assert cfg.outer_dp_size * cfg.attn_dp_size % cfg.nnodes == 0 |
There was a problem hiding this comment.
It is possible that the model does not fit into a single node
Comment on lines
+79
to
+80
| std::string host = std::getenv("LMDEPLOY_DP_MASTER_ADDR"); | ||
| int port = std::stoi(std::getenv("LMDEPLOY_DP_MASTER_PORT")); |
There was a problem hiding this comment.
how is DP related to the surrounding context of this code?
There was a problem hiding this comment.
pt engine use this variables to build dist group. Do we need to choose a new name like dist_init_addr ?
| for (int local_rank = 0, offset = engine_param_.ngpus_per_node * engine_param_.node_rank; | ||
| local_rank < engine_param_.ngpus_per_node; | ||
| ++local_rank) { | ||
| auto& e = engine_params_[offset + local_rank]; |
There was a problem hiding this comment.
adjust the size of engine_params_ to fit ngpus_per_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage
A two node example with tp=4, dp=4 and device_num=4
proxy_server
lmdeploy serve proxy --server-name 10.140.24.141node 0
node 1