-
Notifications
You must be signed in to change notification settings - Fork 46
[Fix] Habitat Refactor & Distributed VLNPE Refactor #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…aac sim gpu setting
…d on lmdb path + rank; remove TODOs and unused files
scripts/eval/eval.py
Outdated
| from internnav.configs.evaluator.vln_default_config import get_config | ||
|
|
||
| evaluator_cfg = get_config(evaluator_cfg) | ||
| elif evaluator_cfg.eval_type == 'habitat_vln': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是干什么的,habitat vln
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个flag没有用到,我去掉
scripts/eval/eval.py
Outdated
| default='scripts/eval/configs/h1_rdp_cfg.py', | ||
| help='eval config file path, e.g. scripts/eval/configs/h1_cma_cfg.py', | ||
| ) | ||
| parser.add_argument('--port', type=int, default=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看server里面写了默认的host和port,这里也写一下会不会好一些,方便跑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,已在AgentConfig里面加了默认的host和port
| def write_now_result_json(self): | ||
| # create log file | ||
| log_content = [] | ||
| # log_content = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused codes
|
|
||
|
|
||
| @Evaluator.register('habitat_vlln') | ||
| class HabitatVlnEvaluator(DistributedEvaluator): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HabitatVLNEvaluator
Please also adjust the names in other places
|
|
||
|
|
||
| @Evaluator.register('habitat_vln') | ||
| class HabitatVlnEvaluator(DistributedEvaluator): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust it as discussed
PR Summary
reset/step, episode assignment, and episode reloading inside the worker, significantly streamlining the evaluation pipeline.Distributed Eval Time
Using 16 nodes, each with 1× RTX 4090 GPU, 8 CPUs, and 60 GB RAM.
Performance after Refactor
InternVLA-N1InternVLA-N1InternVLA-N1RDPRDP