Refactor transValidityInterval: era split, remove protocol branching,… #5147
Conversation
… cleanup Alonzo/Conway logic - 2025-07-01 07:33:54
There was a problem hiding this comment.
Your changes are all correct with respect to Alonzo and Babbage eras, but for Conway you are missing the new implementation of transValidityInterval that did the new style translation. In other words, you can't use the implementation of transValidityInterval from Alonzo in Conway, instead you need a new implementation of this function that has semantics of hardforkConwayTranslateUpperBoundForPlutusScripts
Other than that it looks good.
|
Hey @danbaruka did you still want to finish this task. It's ok if you don't, I can pass this on to finish to one of my teammates, but if you do wanna finish it yourself that is ok too, just let me know. There is no rush. |
|
Hey thanks for your feedback, I'll definitely work on that and fix it as soon as possible. I now understand. |
…; remove outdated Alonzo comment - 2025-07-21 08:18:42
|
Conway: Implement new transValidityInterval with open upper bound semantics; clean up Alonzo comment
|
…tion logic - 2025-07-22 12:06:56
|
All requested changes have been addressed:
Let me know if anything else needs to be updated! |
| pure $ PV1.Interval (PV1.lowerBound PV1.NegInf) (PV1.strictUpperBound t) | ||
| | otherwise -> PV1.to <$> slotToTime i | ||
| ValidityInterval (SJust i) (SJust j) | ||
| | pvMajor pv >= natVersion @9 -> do |
There was a problem hiding this comment.
What's up with this protocol version? The whole reason why this refactoring was suggested precisely to avoid branching on protocol version. Also this function is never gonna be applied to protocol version 9.
…protocol version checks - 2025-07-23 13:53:00
|
Closing in favor of a correctly implemented #5230 |
… cleanup Alonzo/Conway logic - 2025-07-01 07:33:54
Refactor transValidityInterval to use era-specific logic: implement Conway-specific translation (no protocol branching, always strict upper bound), update Conway instances, and clean up Alonzo to always use pre-Conway logic. Remove protocol-version-based branching and obsolete helpers.